docs: fix bq_dataframes_template notebook to work if partial ordering mode is enabled
#1665
Conversation
8000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng mode is enabled
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
Author
|
A good follow-up to this would be to run this notebook in both modes. Edit: filed internal issue 414424250 to track this. |
tswast
commented
Apr 28, 2025
| @@ -114,7 +114,7 @@ | |||
| }, | |||
Collaborator
Author
There was a problem hiding this comment.
Line #1. df.sort_values("body_mass_g").plot(title="Numeric features", logy=True)
Might need a reset_index() call in strict ordering mode for the sort to make any difference there.
Reply via ReviewNB
Collaborator
Author
There was a problem hiding this comment.
Added reset_index in latest commit.
shuoweil
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you uncommented the partial ordering mode line, the notebook would fail.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕