8000 fix: ensure `page_size` works correctly in `to_pandas_batches` when `max_results` is not set by chelsea-lin · Pull Request #1588 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: ensure page_size works correctly in to_pandas_batches when max_results is not set #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chelsea-lin merged 3 commits into from
Apr 3, 2025
Merged

fix: ensure page_size works correctly in to_pandas_batches when max_results is not set #1588

chelsea-lin merged 3 commits into from
Apr 3, 2025

Conversation

@chelsea-lin
Copy link
Contributor
@chelsea-lin chelsea-lin commented Apr 3, 2025

This change fixes an issue that the page_size is ignored in to_pandas_batches when max_results is not set. Also, this change adds code examples for both to_pandas and to_pandas_batches and the doctest can verify the fixes.

Fixes internal issue 407521010🦕

@chelsea-lin chelsea-lin requested review from Genesis929 and tswast April 3, 2025 05:45
@chelsea-lin chelsea-lin requested review from a team as code owners April 3, 2025 05:45
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 3, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_fixpage_size branch from 0c3658a to b162224 Compare April 3, 2025 05:45
tswast
tswast approved these changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chelsea-lin chelsea-lin enabled auto-merge (squash) April 3, 2025 19:06
@chelsea-lin chelsea-lin merged commit 570cff3 into main Apr 3, 2025
18 of 24 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_fixpage_size branch April 3, 2025 19:39
@release-please release-please bot mentioned this pull request Apr 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Al 7622 ready have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@shuoweil shuoweil shuoweil approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929

Assignees

@shuoweil shuoweil

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin @tswast @shuoweil
0