8000 feat: add `closed` parameter in rolling() by sycai · Pull Request #1539 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

feat: add closed parameter in rolling() #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sycai merged 7 commits into from
Mar 26, 2025
Merged

feat: add closed parameter in rolling() #1539

sycai merged 7 commits into from
Mar 26, 2025

Conversation

@sycai
Copy link
Contributor
@sycai sycai commented Mar 25, 2025

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 25, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 25, 2025
@sycai sycai marked this pull request as ready for review March 26, 2025 17:03
@sycai sycai requested review from a team as code owners March 26, 2025 17:03
@sycai sycai requested a review from shobsi March 26, 2025 17:03
@sycai sycai requested review from TrevorBergeron and chelsea-lin and removed request for shobsi March 26, 2025 17:03
@sycai sycai merged commit 8bcc89b into main Mar 26, 2025
23 of 24 checks passed
@sycai sycai deleted the sycai_rolling_window branch March 26, 2025 18:54
@release-please release-please bot mentioned this pull request 8000 Mar 26, 2025
Merged
shobsi pushed a commit that referenced this pull request Mar 28, 2025
@sycai @shobsi
feat: add closed parameter in rolling() (#1539)
83379a4 
* feat: add  parameter in rolling()

* beautify code
@release-please release-please bot mentioned this pull request Mar 28, 2025
Closed
@sycai sycai mentioned this pull request Mar 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Assignees

@jialuoo jialuoo

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sycai @chelsea-lin @jialuoo
0