8000 feat: warn if default cloud_function_service_account is used by arwas11 · Pull Request #1424 · googleapis/python-bigquery-dataframes · GitHub 8000
[go: up one dir, main page]
Skip to content

feat: warn if default cloud_function_service_account is used #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 13 commits into from
Mar 1, 2025
Merged

feat: warn if default cloud_function_service_account is used #1424

tswast merged 13 commits into from
Mar 1, 2025

Conversation

@arwas11
Copy link
Contributor
@arwas11 arwas11 commented Feb 24, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • remote_function: screen/7fcCN7xwHwzZ6Bb
      Fixes #398853216 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 24, 2025
@review-notebook-app
Copy link
review-notebook-app bot commented Feb 24, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 24, 2025
@arwas11 arwas11 marked this pull request as ready for review February 27, 2025 19:33
@arwas11 arwas11 requested review from a team as code owners February 27, 2025 19:33
chelsea-lin
chelsea-lin reviewed Feb 27, 2025
View reviewed changes
tswast
tswast reviewed Feb 27, 2025
View reviewed changes
tswast
tswast reviewed Feb 28, 2025
View reviewed changes
tswast
tswast reviewed Feb 28, 2025
View reviewed changes
tests/system/large/functions/test_remote_function.py Outdated
with pytest.warns(FutureWarning, match="You have not explicitly set a"):
warnings.simplefilter("always")

@rf_session.remote_function(
Copy link
Collaborator
@tswast tswast Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't actually have to deploy a function to test this warning. Will try something and add a commit if so.

@tswast tswast enabled auto-merge (squash) February 28, 2025 23:06
@tswast tswast merged commit fe7463a into main Mar 1, 2025
22 of 23 checks passed
@tswast tswast deleted the b398853216-service-account-warning branch March 1, 2025 00:33
@release-please release-please bot mentioned this pull request Mar 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin left review comments

@tswast tswast tswast approved these changes

Assignees

@rey-esp rey-esp

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arwas11 @tswast @chelsea-lin @rey-esp
0