8000 fix: Fix null index join with 'on' arg by TrevorBergeron · Pull Request #1153 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: Fix null index join with 'on' arg #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TrevorBergeron merged 3 commits into from
Nov 21, 2024
Merged

fix: Fix null index join with 'on' arg #1153

TrevorBergeron merged 3 commits into from
Nov 21, 2024

Conversation

@TrevorBergeron
Copy link
Contributor
@TrevorBergeron TrevorBergeron commented Nov 14, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners November 14, 2024 21:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 14, 2024
shobsi
shobsi reviewed Nov 17, 2024
View reviewed changes
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 20, 2024
@TrevorBergeron TrevorBergeron merged commit 9015c33 into main Nov 21, 2024
22 of 23 checks passed
@TrevorBergeron TrevorBergeron deleted the null_join_on branch November 21, 2024 22:02
@release-please release-please bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi approved these changes

Assignees

@junyazhang junyazhang

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @shobsi @junyazhang
0