8000 feat: update LLM generators to warn user about model name instead of raising error. by Genesis929 · Pull Request #1048 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

feat: update LLM generators to warn user about model name instead of raising error. #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shobsi merged 3 commits into from
Oct 8, 2024
Merged

feat: update LLM generators to warn user about model name instead of raising error. #1048

shobsi merged 3 commits into from
Oct 8, 2024

Conversation

@Genesis929
Copy link
Collaborator
@Genesis929 Genesis929 commented Oct 3, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 3, 2024
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2024
@Genesis929 Genesis929 marked this pull request as ready for review October 3, 2024 22:46
@Genesis929 Genesis929 requested review from a team as code owners October 3, 2024 22:46
@Genesis929 Genesis929 requested a review from shobsi October 3, 2024 22:46
shobsi
shobsi reviewed 8000 Oct 3, 2024
View reviewed changes
bigframes/ml/llm.py Outdated
f"Model name {self.model_name} is not supported. We only support {', '.join(_TEXT_GENERATOR_ENDPOINTS)}."
warnings.warn(
f"Model name '{self.model_name}' is not supported. "
f"We currently support the following models: {', '.join(_TEXT_GENERATOR_ENDPOINTS)}. "
Copy link
Contributor
@shobsi shobsi Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say "We currently support" -> "We are currently aware of"

Copy link
Collaborator Author
@Genesis929 Genesis929 Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. That sounds better, thanks.

@Genesis929 Genesis929 requested a review from shobsi October 4, 2024 06:40
@shobsi shobsi merged commit 650d80d into main Oct 8, 2024
@shobsi shobsi deleted the model_support_warning_huanc branch October 8, 2024 00:34
@release-please release-please bot mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi approved these changes

Assignees

@jiaxunwu jiaxunwu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Genesis929 @shobsi @jiaxunwu
0