8000 docs: Revise update_table_expiration sample by thejaredchapman · Pull Request #1457 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

docs: Revise update_table_expiration sample #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

docs: Revise update_table_expiration sample #1457

merged 2 commits into from
Sep 15, 2023

Conversation

thejaredchapman
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 🦕

@thejaredchapman thejaredchapman requested a review from a team January 9, 2023 20:25
@thejaredchapman thejaredchapman requested review from a team as code owners January 9, 2023 20:25
@snippet-bot
Copy link
snippet-bot bot commented Jan 9, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 9, 2023
tswast
tswast requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But let's update docs/snippets.py with a comment that we should delete the duplicate sample there once we update cloud.google.com.

@thejaredchapman thejaredchapman mentioned this pull request Mar 3, 2023
Closed
4 tasks
@tswast
Copy link
Contributor
tswast commented Mar 8, 2023

@thejaredchapman I think we might want to rebase this just so we can fixup the CLA check.

Would love to see the commit for #1516 as part of this PR instead of as a second PR, too.

@thejaredchapman thejaredchapman enabled auto-merge (squash) March 8, 2023 21:27
@meredithslota meredithslota requested a review from a team as a code owner April 11, 2023 20:39
@meredithslota meredithslota added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2023
@meredithslota
Copy link
Contributor
meredithslota commented Apr 11, 2023 •
edited
Loading

Manually applied the cla: yes label since it's related to a Xoogler contribution made during employment.

edit This didn't work, ha — someone will need to click the "request exception" link in the CLA checker log.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 11, 2023
@tswast tswast force-pushed the issue790-update_table_expiration branch from 494f9b7 to deff4ad Compare September 15, 2023 16:30
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 15, 2023
@tswast
Copy link
Contributor
tswast commented Sep 15, 2023

I've squashed all commits and re-pushed. I believe that should resolve the CLA issue.

@thejaredchapman thejaredchapman merged commit 03194e0 into main Sep 15, 2023
@thejaredchapman thejaredchapman deleted the issue790-update_table_expiration branch September 15, 2023 18:17
@release-please release-please bot mentioned this pull request Sep 15, 2023
Merged
tswast added a commit that referenced this pull request Oct 4, 2023
@tswast
docs: remove redundant bigquery_update_table_expiration code sample
a248c00 
New version of this sample added in #1457 and migrated to in the docs in internal change 570781706.
@tswast tswast mentioned this pull request Oct 4, 2023
Merged
4 tasks
This was referenced Oct 10, 2023
Closed
Closed
Closed
Linchin added a commit that referenced this pull request Oct 19, 2023
@tswast @Linchin
docs: remove redundant bigquery_update_table_expiration code sample (…
2dded33 
…#1673)

New version of this sample added in #1457 and migrated to in the docs in internal change 570781706.

Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

@nicain nicain Awaiting requested review from nicain nicain is a code owner automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejaredchapman @tswast @meredithslota
0