8000 fix: Add More Specific Type Annotations for Row Dictionaries by waltaskew · Pull Request #1295 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

fix: Add More Specific Type Annotations for Row Dictionaries #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2022
Merged

fix: Add More Specific Type Annotations for Row Dictionaries #1295

merged 4 commits into from
Nov 16, 2022

Conversation

waltaskew
Copy link
Contributor
  • The keys must be strings as they represent column names. Update type
    annotations to reflect this.

@waltaskew waltaskew requested a review from a team July 20, 2022 21:47
@waltaskew waltaskew requested a review from a team as a code owner July 20, 2022 21:47
@waltaskew waltaskew requested a review from Neenu1995 July 20, 2022 21:47
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 20, 2022
@waltaskew waltaskew force-pushed the better-type-annotations branch from 686ba40 to 70c643e Compare July 22, 2022 22:23
@waltaskew waltaskew force-pushed the better-type-annotations branch from 70c643e to ec97e77 Compare August 1, 2022 21:22
@waltaskew
feat: Add More Specific Type Annotations for Row Dictionaries
0468067 
The keys must be strings as they represent column names. Update type annotations
to reflect this.
@waltaskew waltaskew force-pushed the better-type-annotations branch from ec97e77 to 0468067 Compare August 11, 2022 23:27
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. 8000 labels Aug 12, 2022
@parthea parthea requested a review from chalmerlowe September 6, 2022 19:42
@parthea
Copy link
Contributor
parthea commented Sep 6, 2022

@chalmerlowe Please could you take a look?

@aribray aribray changed the title Add More Specific Type Annotations for Row Dictionaries fix: Add More Specific Type Annotations for Row Dictionaries Nov 10, 2022
@aribray aribray added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 10, 2022
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@aribray
Copy link
Contributor
8000
aribray commented Nov 15, 2022

@parthea sorry for the delay. I reviewed/tested this and it was all good!

@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@parthea parthea merged commit eb49873 into googleapis:main Nov 16, 2022
@release-please release-please bot mentioned this pull request Nov 16, 2022
Merged
This was referenced Nov 22, 2022
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@waltaskew @aribray @abdelmegahedgoogle
feat: Add More Specific Type Annotations for Row Dictionaries (google…
1215aa6 
…apis#1295)

The keys must be strings as they represent column names. Update type annotations
to reflect this.

Co-authored-by: aribray <45905583+aribray@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

1 more reviewer

@aribray aribray aribray approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowe chalmerlowe

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@waltaskew @parthea @aribray @chalmerlowe @yoshi-kokoro
0