add comment

parthea · parthea · commit d72dfb431c6e · 2024-10-15T16:04:12.000Z
diff --git a/proto/enums.py b/proto/enums.py
@@ -73,6 +73,8 @@ def __new__(mcls, name, bases, attrs):
                 (
                     descriptor_pb2.EnumValueDescriptorProto(name=name, number=number)
                     # Minor hack to get all the enum variants out.
+                    # Use the `_member_names` property to get only the enum members
+                    # See https://github.com/googleapis/proto-plus-python/issues/490
                     for name, number in attrs.items()
                     if name in attrs._member_names and isinstance(number, int)
                 ),

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,8 @@ def __new__(mcls, name, bases, attrs):`
`73`	`73`	`(`
`74`	`74`	`descriptor_pb2.EnumValueDescriptorProto(name=name, number=number)`
`75`	`75`	`# Minor hack to get all the enum variants out.`
	`76`	+ # Use the `_member_names` property to get only the enum members
	`77`	`+ # See https://github.com/googleapis/proto-plus-python/issues/490`
`76`	`78`	`for name, number in attrs.items()`
`77`	`79`	`if name in attrs._member_names and isinstance(number, int)`
`78`	`80`	`),`