10000 fix: backtick `table_name` to allow all characters for MySQLChatMessageHistory by jackwotherspoon · Pull Request #15 · googleapis/langchain-google-cloud-sql-mysql-python · GitHub
[go: up one dir, main page]
Skip to content

fix: backtick table_name to allow all characters for MySQLChatMessageHistory #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix: backtick table_name to allow all characters for MySQLChatMessageHistory #15

merged 2 commits into from
Feb 5, 2024

Conversation

jackwotherspoon
Copy link
Contributor

Adding backticks around custom table name for MySQLChatMessageHistory, this allows for table names with SQL special characters such as a hyphen, (ie. table_name="my-table")

@jackwotherspoon jackwotherspoon self-assigned this Feb 5, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner February 5, 2024 16:50
@jackwotherspoon jackwotherspoon merged commit d1ce730 into main Feb 5, 2024
@jackwotherspoon jackwotherspoon deleted the fix-table-name branch February 5, 2024 16:59
@release-please release-please bot mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwotherspoon @kurtisvg
0