googleapis / google-cloud-python Public

Notifications You must be signed in to change notification settings
Fork 1.6k
Star 5.1k

< 8000 tool-tip id="tooltip-527606c6-0b5c-4b30-81f1-34d854815260" for="action-menu-1157fa07-9c83-4fc1-aa33-d5c66dcc512f-button" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Additional navigation options

#260: break datastore cycles via factories#268

Closed

tseaver wants to merge 11 commits intogoogleapis:masterfrom

tseaver:260-break_datastore_cycles_via_factories

Commits on Oct 22, 2014

Drop 'Dataset.query' and 'Dataset.entity' convenience APIs.
tseaver
committed
Add a factory registry to datastore._helpers.
tseaver
committed
Break import cycles via a factory registry.
tseaver
committed
Tidy local imports, remove remaining cycles.
tseaver
committed
Fix build: invoke correct factory when unmarshalling key from pb.
tseaver
committed
Reorder 'Query.__init__' paramters to match Entity.
tseaver
committed
Rename '_query_factory' helper -> '_get_factory' to avoid confustion.
tseaver
committed
Avoid relative imports.
tseaver
committed
Encapsulate factory registry as a singleton object.
tseaver
committed
Rename alternate factories for clarity.
tseaver
committed
Use 'invoke' rather than 'get' followed by call to invoke factories.
tseaver
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

#260: break datastore cycles via factories#268

#260: break datastore cycles via factories#268
tseaver wants to merge 11 commits intogoogleapis:masterfrom
tseaver:260-break_datastore_cycles_via_factories

Commits on Oct 22, 2014

Drop 'Dataset.query' and 'Dataset.entity' convenience APIs.

Add a factory registry to datastore._helpers.

Break import cycles via a factory registry.

Tidy local imports, remove remaining cycles.

Fix build: invoke correct factory when unmarshalling key from pb.

Reorder 'Query.init' paramters to match Entity.

Rename '_query_factory' helper -> '_get_factory' to avoid confustion.

Avoid relative imports.

Encapsulate factory registry as a singleton object.

Rename alternate factories for clarity.

Use 'invoke' rather than 'get' followed by call to invoke factories.

#260: break datastore cycles via factories#268tseaver wants to merge 11 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:260-break_datastore_cycles_via_factoriesCopy head branch name to clipboard

Commits

Commits on Oct 22, 2014

#260: break datastore cycles via factories#268
tseaver wants to merge 11 commits intogoogleapis:masterfrom
tseaver:260-break_datastore_cycles_via_factories