8000 Remove old/unused Bigtable v1 generated code by dhermes · Pull Request #1999 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Remove old/unused Bigtable v1 generated code #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2016
Merged

Remove old/unused Bigtable v1 generated code #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95d6a67
Removing Bigtable v1 generated code.
dhermes Jul 19, 2016
dfea540
Removing all references to generated_v2.
dhermes Jul 19, 2016
5d8ec27
Renaming _generated_v2 to _generated in bigtable.
dhermes Jul 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[report]
omit =
*/_generated/*.py
*/_generated_v2/*.py
show_missing = True
exclude_lines =
# Re-enable the standard pragma
Expand Down
81 changes: 0 additions & 81 deletions Makefile.bigtable_v1
View file
Open in desktop

This file was deleted.

8 changes: 2 additions & 6 deletions Makefile.bigtable_v2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
GRPCIO_VIRTUALENV=$(shell pwd)/grpc_python_venv
GENERATED_DIR=$(shell pwd)/generated_python
GENERATED_SUBDIR=_generated_v2
GENERATED_SUBDIR=_generated
BIGTABLE_DIR=$(shell pwd)/gcloud/bigtable/$(GENERATED_SUBDIR)
PROTOC_CMD=$(GRPCIO_VIRTUALENV)/bin/python -m grpc.tools.protoc
GOOGLEAPIS_PROTOS_DIR=$(shell pwd)/googleapis-pb
Expand All @@ -9,7 +9,6 @@ help:
@echo 'Makefile for gcloud-python Bigtable protos '
@echo ' '
@echo ' make generate Generates the protobuf modules '
@echo ' make check_generate Checks that generate succeeded '
@echo ' make clean Clean generated files '

generate:
Expand Down Expand Up @@ -62,10 +61,7 @@ generate:
# Rewrite the imports in the generated *_pb2.py files.
python scripts/rewrite_imports.py $(BIGTABLE_DIR)/*pb2.py

check_generate:
python scripts/check_generate.py

clean:
rm -fr $(GRPCIO_VIRTUALENV) $(GOOGLEAPIS_PROTOS_DIR) $(GENERATED_DIR)

.PHONY: generate check_generate clean
.PHONY: generate clean
6 changes: 1 addition & 5 deletions Makefile.datastore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ help:
@echo 'Makefile for gcloud-python Bigtable protos '
@echo ' '
@echo ' make generate Generates the protobuf modules '
@echo ' make check_generate Checks that generate succeeded '
@echo ' make clean Clean generated files '

generate:
Expand Down Expand Up @@ -48,10 +47,7 @@ generate:
# Rewrite the imports in the generated *_pb2.py files.
python scripts/rewrite_imports.py $(DATASTORE_DIR)/*pb2.py

check_generate:
python scripts/check_generate.py

clean:
rm -fr $(GENERATED_DIR)

.PHONY: generate check_generate clean
.PHONY: generate clean
0 ...ud/bigtable/_generated_v2/_bigtable.proto → gcloud/bigtable/_generated/_bigtable.proto
View file
Open in desktop
File renamed without changes.
93 changes: 0 additions & 93 deletions gcloud/bigtable/_generated/_bigtable_cluster_data.proto
View file
Open in desktop

This file was deleted.

129 changes: 0 additions & 129 deletions gcloud/bigtable/_generated/_bigtable_cluster_service.proto
View file
Open in desktop

This file was deleted.

Loading
0