8000 Revert dropping 'fields' from existence-check GET. · googleapis/google-cloud-python@b44aea9 · GitHub
[go: up one dir, main page]

Skip to content

Commit b44aea9

Browse files
committed
Revert dropping 'fields' from existence-check GET.
Per: #794 (comment)
1 parent 8ba7e36 commit b44aea9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

gcloud/pubsub/subscription.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ def exists(self):
7474
"""
7575
conn = self.topic.connection
7676
try:
77-
conn.api_request(method='GET', path=self.path)
77+
conn.api_request(method='GET', path=self.path,
78+
query_params={'fields': 'name'})
7879
except NotFound:
7980
return False
8081
else:

gcloud/pubsub/test_subscription.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def test_exists_miss(self):
9595
req = conn._requested[0]
9696
self.assertEqual(req['method'], 'GET')
9797
self.assertEqual(req['path'], '/%s' % SUB_PATH)
98-
self.assertEqual(req.get('query_params'), None)
98+
self.assertEqual(req['query_params'], {'fields': 'name'})
9999

100100
def test_exists_hit(self):
101101
PROJECT = 'PROJECT'
@@ -111,7 +111,7 @@ def test_exists_hit(self):
111111
req = conn._requested[0]
112112
self.assertEqual(req['method'], 'GET')
113113
self.assertEqual(req['path'], '/%s' % SUB_PATH)
114-
self.assertEqual(req.get('query_params'), None)
114+
self.assertEqual(req['query_params'], {'fields': 'name'})
115115

116116
def test_reload(self):
117117
PROJECT = 'PROJECT'

0 commit comments

Comments
 (0)
0