8000 fix: Add async context manager return types (#318) · googleapis/google-cloud-python@ac40f41 · GitHub
[go: up one dir, main page]
Skip to content

Commit ac40f41

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: Add async context manager return types (#318)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent ec4ddf4 commit ac40f41

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

‎packages/google-cloud-trace/google/cloud/trace_v1/services/trace_service/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ async def sample_patch_traces():
584584
metadata=metadata,
585585
)
586586

587-
async def __aenter__(self):
587+
async def __aenter__(self) -> "TraceServiceAsyncClient":
588588
return self
589589

590590
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-trace/google/cloud/trace_v2/services/trace_service/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ async def sample_create_span():
446446
# Done; return the response.
447447
return response
448448

449-
async def __aenter__(self):
449+
async def __aenter__(self) -> "TraceServiceAsyncClient":
450450
return self
451451

452452
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-trace/samples/generated_samples/snippet_metadata_google.devtools.cloudtrace.v1.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-trace",
11-
"version": "1.11.1"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎packages/google-cloud-trace/samples/generated_samples/snippet_metadata_google.devtools.cloudtrace.v2.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-trace",
11-
"version": "1.11.1"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎packages/google-cloud-trace/tests/unit/gapic/trace_v1/test_trace_service.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,9 +1106,11 @@ async def test_list_traces_async_pages():
11061106
RuntimeError,
11071107
)
11081108
pages = []
1109-
async for page_ in (
1109+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1110+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1111+
async for page_ in ( # pragma: no branch
11101112
await client.list_traces(request={})
1111-
).pages: # pragma: no branch
1113+
).pages:
11121114
pages.append(page_)
11131115
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11141116
assert page_.raw_page.next_page_token == token

0 commit comments

Comments
 (0)
0