8000 Clarify why 'reload_metadata' uses 'projection=noAcl'. · googleapis/google-cloud-python@a4bb709 · GitHub
[go: up one dir, main page]

Skip to content

Commit a4bb709

Browse files
committed
Clarify why 'reload_metadata' uses 'projection=noAcl'.
1 parent 4dde9cb commit a4bb709

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

gcloud/storage/bucket.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,8 @@ def reload_metadata(self):
328328
:rtype: :class:`Bucket`
329329
:returns: The bucket you just reloaded data for.
330330
"""
331+
# Pass only '?projection=noAcl' here because 'acl'/'defaultObjectAcl'
332+
# are handled via 'get_acl()'/'get_default_object_acl()'
331333
query_params = {'projection': 'noAcl'}
332334
self.metadata = self.connection.api_request(
333335
method='GET', path=self.path, query_params=query_params)

gcloud/storage/key.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,8 @@ def reload_metadata(self):
321321
:rtype: :class:`Key`
322322
:returns: The key you just reloaded data for.
323323
"""
324+
# Pass only '?projection=noAcl' here because 'acl' is handled via
325+
# 'get_acl().
324326
query_params = {'projection': 'noAcl'}
325327
self.metadata = self.connection.api_request(
326328
method='GET', path=self.path, query_params=query_params)

0 commit comments

Comments
 (0)
0