From 7a599608acb9b88ea047bad1bbdee98e10f0651d Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 12:30:14 -0500 Subject: [PATCH 01/13] Bigtable: merge bigtable-admin into the bigtable artifact --- .kokoro/continuous/bigtableadmin-it.cfg | 27 ---- .kokoro/nightly/bigtableadmin-it.cfg | 27 ---- .kokoro/presubmit/bigtableadmin-it.cfg | 27 ---- .../google-cloud-bigtable-admin/README.md | 133 +----------------- .../google-cloud-bigtable-admin/pom.xml | 111 +-------------- .../admin/v2/internal/DeprecationMarker.java | 28 ++++ .../synth.metadata | 27 ---- .../google-cloud-bigtable-admin/synth.py | 40 ------ .../google-cloud-bigtable/README.md | 16 +-- .../google-cloud-bigtable/pom.xml | 6 + .../v2/BaseBigtableInstanceAdminClient.java | 0 .../v2/BaseBigtableInstanceAdminSettings.java | 0 .../v2/BaseBigtableTableAdminClient.java | 5 + .../v2/BaseBigtableTableAdminSettings.java | 0 .../admin/v2/BigtableInstanceAdminClient.java | 7 +- .../v2/BigtableInstanceAdminSettings.java | 0 .../admin/v2/BigtableTableAdminClient.java | 0 .../admin/v2/BigtableTableAdminSettings.java | 0 .../internal/ArtifactDeprecationChecker.java | 51 +++++++ .../bigtable/admin/v2/internal/NameUtil.java | 0 .../bigtable/admin/v2/models/AppProfile.java | 0 .../bigtable/admin/v2/models/Cluster.java | 0 .../admin/v2/models/ColumnFamily.java | 0 .../v2/models/CreateAppProfileRequest.java | 0 .../admin/v2/models/CreateClusterRequest.java | 0 .../v2/models/CreateInstanceRequest.java | 0 .../admin/v2/models/CreateTableRequest.java | 0 .../bigtable/admin/v2/models/GCRules.java | 0 .../bigtable/admin/v2/models/Instance.java | 0 .../models/ModifyColumnFamiliesRequest.java | 0 .../models/PartialListClustersException.java | 0 .../models/PartialListInstancesException.java | 0 .../bigtable/admin/v2/models/StorageType.java | 0 .../cloud/bigtable/admin/v2/models/Table.java | 0 .../v2/models/UpdateAppProfileRequest.java | 0 .../v2/models/UpdateInstanceRequest.java | 0 .../cloud/bigtable/admin/v2/package-info.java | 0 .../v2/stub/AwaitReplicationCallable.java | 0 .../v2/stub/BigtableInstanceAdminStub.java | 0 .../BigtableInstanceAdminStubSettings.java | 0 .../admin/v2/stub/BigtableTableAdminStub.java | 0 .../stub/BigtableTableAdminStubSettings.java | 0 .../stub/EnhancedBigtableTableAdminStub.java | 0 ...cBigtableInstanceAdminCallableFactory.java | 0 .../stub/GrpcBigtableInstanceAdminStub.java | 0 ...GrpcBigtableTableAdminCallableFactory.java | 0 .../v2/stub/GrpcBigtableTableAdminStub.java | 0 .../BaseBigtableInstanceAdminClientTest.java | 0 .../v2/BaseBigtableTableAdminClientTest.java | 0 .../v2/BigtableInstanceAdminClientTest.java | 0 .../v2/BigtableInstanceAdminSettingsTest.java | 0 .../v2/BigtableTableAdminClientTest.java | 0 .../v2/BigtableTableAdminSettingsTest.java | 0 .../admin/v2/MockBigtableInstanceAdmin.java | 0 .../v2/MockBigtableInstanceAdminImpl.java | 0 .../admin/v2/MockBigtableTableAdmin.java | 0 .../admin/v2/MockBigtableTableAdminImpl.java | 0 .../v2/it/BigtableTableAdminClientIT.java | 0 .../admin/v2/models/AppProfileTest.java | 0 .../bigtable/admin/v2/models/ClusterTest.java | 0 .../models/CreateAppProfileRequestTest.java | 0 .../v2/models/CreateClusterRequestTest.java | 0 .../bigtable/admin/v2/models/GCRulesTest.java | 0 .../admin/v2/models/InstanceTest.java | 0 .../admin/v2/models/StorageTypeTest.java | 0 .../v2/models/TableAdminRequestsTest.java | 0 .../bigtable/admin/v2/models/TableTest.java | 0 .../models/UpdateAppProfileRequestTest.java | 0 .../v2/models/UpdateInstanceRequestTest.java | 0 .../v2/stub/AwaitReplicationCallableTest.java | 0 .../google-cloud-bigtable/synth.py | 53 ++++--- 71 files changed, 141 insertions(+), 417 deletions(-) delete mode 100644 .kokoro/continuous/bigtableadmin-it.cfg delete mode 100644 .kokoro/nightly/bigtableadmin-it.cfg delete mode 100644 .kokoro/presubmit/bigtableadmin-it.cfg create mode 100644 google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/internal/DeprecationMarker.java delete mode 100644 google-cloud-clients/google-cloud-bigtable-admin/synth.metadata delete mode 100644 google-cloud-clients/google-cloud-bigtable-admin/synth.py rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminSettings.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java (99%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java (99%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettings.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettings.java (100%) create mode 100644 google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/internal/ArtifactDeprecationChecker.java rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/internal/NameUtil.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/AppProfile.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/Cluster.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/ColumnFamily.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateInstanceRequest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateTableRequest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/GCRules.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/Instance.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/ModifyColumnFamiliesRequest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListClustersException.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListInstancesException.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/StorageType.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/Table.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/package-info.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallable.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStub.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminCallableFactory.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminStub.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminCallableFactory.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClientTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClientTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClientTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettingsTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettingsTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdmin.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdminImpl.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdmin.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/AppProfileTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/ClusterTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequestTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequestTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/GCRulesTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/InstanceTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/StorageTypeTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequestTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequestTest.java (100%) rename google-cloud-clients/{google-cloud-bigtable-admin => google-cloud-bigtable}/src/test/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallableTest.java (100%) diff --git a/.kokoro/continuous/bigtableadmin-it.cfg b/.kokoro/continuous/bigtableadmin-it.cfg deleted file mode 100644 index 5625893dd94b..000000000000 --- a/.kokoro/continuous/bigtableadmin-it.cfg +++ /dev/null @@ -1,27 +0,0 @@ -# Format: //devtools/kokoro/config/proto/build.proto - -# Configure the docker image for kokoro-trampoline. -env_vars: { - key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/java8" -} - -env_vars: { - key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable-admin -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" -} - -env_vars: { - key: "JOB_TYPE" - value: "integration" -} - -env_vars: { - key: "GCLOUD_PROJECT" - value: "gcloud-devel" -} - -env_vars: { - key: "GOOGLE_APPLICATION_CREDENTIALS" - value: "keystore/73713_java_it_service_account" -} diff --git a/.kokoro/nightly/bigtableadmin-it.cfg b/.kokoro/nightly/bigtableadmin-it.cfg deleted file mode 100644 index 5625893dd94b..000000000000 --- a/.kokoro/nightly/bigtableadmin-it.cfg +++ /dev/null @@ -1,27 +0,0 @@ -# Format: //devtools/kokoro/config/proto/build.proto - -# Configure the docker image for kokoro-trampoline. -env_vars: { - key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/java8" -} - -env_vars: { - key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable-admin -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" -} - -env_vars: { - key: "JOB_TYPE" - value: "integration" -} - -env_vars: { - key: "GCLOUD_PROJECT" - value: "gcloud-devel" -} - -env_vars: { - key: "GOOGLE_APPLICATION_CREDENTIALS" - value: "keystore/73713_java_it_service_account" -} diff --git a/.kokoro/presubmit/bigtableadmin-it.cfg b/.kokoro/presubmit/bigtableadmin-it.cfg deleted file mode 100644 index 5625893dd94b..000000000000 --- a/.kokoro/presubmit/bigtableadmin-it.cfg +++ /dev/null @@ -1,27 +0,0 @@ -# Format: //devtools/kokoro/config/proto/build.proto - -# Configure the docker image for kokoro-trampoline. -env_vars: { - key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/java8" -} - -env_vars: { - key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable-admin -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" -} - -env_vars: { - key: "JOB_TYPE" - value: "integration" -} - -env_vars: { - key: "GCLOUD_PROJECT" - value: "gcloud-devel" -} - -env_vars: { - key: "GOOGLE_APPLICATION_CREDENTIALS" - value: "keystore/73713_java_it_service_account" -} diff --git a/google-cloud-clients/google-cloud-bigtable-admin/README.md b/google-cloud-clients/google-cloud-bigtable-admin/README.md index c3ab04696faf..34e1d679997d 100644 --- a/google-cloud-clients/google-cloud-bigtable-admin/README.md +++ b/google-cloud-clients/google-cloud-bigtable-admin/README.md @@ -1,133 +1,4 @@ # Google Cloud Java Client for Bigtable Admin -Java idiomatic client for [Cloud Bigtable Admin][cloud-bigtable]. Please note that this client is under -heavy development and is not ready for production use. Please continue to use the -[HBase API client](https://github.com/GoogleCloudPlatform/cloud-bigtable-client) for production. - -[![Kokoro CI](http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/master.svg)](http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/master.html) -[![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-bigtable.svg)](https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-bigtable-admin.svg) -[![Codacy Badge](https://api.codacy.com/project/badge/grade/9da006ad7c3a4fe1abd142e77c003917)](https://www.codacy.com/app/mziccard/google-cloud-java) - -- [Product Documentation][bigtable-product-docs] -- [Client Library Documentation][bigtable-admin-client-lib-docs] - -> Note: This client is under heavy development and should not be used in production. - -## Quickstart - -[//]: # ({x-version-update-start:google-cloud-bigtable-admin:released}) -If you are using Maven, add this to your pom.xml file -```xml - - com.google.cloud - google-cloud-bigtable-admin - 0.76.0-alpha - -``` -If you are using Gradle, add this to your dependencies -```Groovy -compile 'com.google.cloud:google-cloud-bigtable-admin:0.76.0-alpha' -``` -If you are using SBT, add this to your dependencies -```Scala -libraryDependencies += "com.google.cloud" % "google-cloud-bigtable-admin" % "0.76.0-alpha" -``` -[//]: # ({x-version-update-end}) - -## Authentication - -See the -[Authentication](https://github.com/GoogleCloudPlatform/google-cloud-java#authentication) -section in the base directory's README. - -## About Cloud Bigtable Admin - -[Cloud Bigtable][cloud-bigtable] is Google's NoSQL Big Data database service. It's -the same database that powers many core Google services, including Search, Analytics, Maps, and -Gmail. The API is split into the data api and the admin api. This client targets the admin api. - -Be sure to activate the Cloud Bigtable Admin API on the Developer's Console to use Cloud Bigtable -from your project. - -See the [Bigtable Amin client lib docs][bigtable-admin-client-lib-docs] to learn how to -interact with Cloud Bigtable Admin API using this Client Library. - -## Getting Started -#### Prerequisites -For this tutorial, you will need a -[Google Developers Console](https://console.developers.google.com/) project with the Cloud Bigtable -API enabled. You will need to -[enable billing](https://support.google.com/cloud/answer/6158867?hl=en) to use Google Cloud Bigtable. -[Follow these instructions](https://cloud.google.com/resource-manager/docs/creating-managing-projects) to get your -project set up. You will also need to set up the local development environment by [installing the -Google Cloud SDK](https://cloud.google.com/sdk/) and running the following commands in command line: -`gcloud auth login`. - -#### Calling Cloud Bigtable - -The Cloud Bigtable API is split into 2 parts: Data API, Instance Admin API and Table Admin API. - -Here is a code snippet showing simple usage of the Table API. Add the following imports -at the top of your file: - - -```java -import static com.google.cloud.bigtable.admin.v2.models.GCRules.GCRULES; -import com.google.bigtable.admin.v2.InstanceName; -import com.google.cloud.bigtable.admin.v2.BigtableTableAdminClient; -import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest; -import com.google.cloud.bigtable.admin.v2.models.Table; -``` - -Then, to create a table, use the following code: -```java -InstanceName instanceName = InstanceName.of("my-project", "my-instance"); - -BigtableTableAdminClient tableAdminClient = BigtableTableAdminClient.create(instanceName); - -try { - Table createdTable = tableAdminClient.createTable( - CreateTableRequest.of("my-table") - .addFamily("cf2", GCRULES.maxVersions(10)); -} finally { - tableAdminClient.close(); -} -``` - -## Troubleshooting - -To get help, follow the instructions in the [shared Troubleshooting -document](https://github.com/googleapis/google-cloud-common/blob/master/troubleshooting/readme.md#troubleshooting). - -Transport ---------- -Bigtable uses gRPC for the transport layer. - -## Java Versions - -Java 7 or above is required for using this client. - -## Versioning - -This library follows [Semantic Versioning](http://semver.org/). - -It is currently in major version zero (`0.y.z`), which means that anything may -change at any time and the public API should not be considered stable. - -## Contributing - -Contributions to this library are always welcome and highly encouraged. - -See [CONTRIBUTING] for more information on how to get started and [DEVELOPING] for a layout of the -codebase. - -## License - -Apache 2.0 - See [LICENSE] for more information. - -[CONTRIBUTING]:https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/CONTRIBUTING.md -[LICENSE]: https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/LICENSE -[cloud-platform]: https://cloud.google.com/ -[cloud-bigtable]: https://cloud.google.com/bigtable/ -[bigtable-product-docs]: https://cloud.google.com/bigtable/docs/ -[bigtable-admin-client-lib-docs]: https://googleapis.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/bigtable/admin/v2/package-summary.html +This project has been merged into google-cloud-bigtable and will soon +be deleted. \ No newline at end of file diff --git a/google-cloud-clients/google-cloud-bigtable-admin/pom.xml b/google-cloud-clients/google-cloud-bigtable-admin/pom.xml index d0b30c692aa5..3102554f3079 100644 --- a/google-cloud-clients/google-cloud-bigtable-admin/pom.xml +++ b/google-cloud-clients/google-cloud-bigtable-admin/pom.xml @@ -14,119 +14,10 @@ google-cloud-clients 0.76.1-alpha-SNAPSHOT - - google-cloud-bigtable-admin - ${project.groupId} - google-cloud-core - - - ${project.groupId} - google-cloud-core-grpc - - - com.google.api.grpc - proto-google-cloud-bigtable-admin-v2 - - - com.google.api.grpc - grpc-google-cloud-bigtable-admin-v2 - test - - - io.grpc - grpc-netty-shaded - - - io.grpc - grpc-stub - - - io.grpc - grpc-auth - - - - com.google.auto.value - auto-value - provided - - - - - com.google.api - gax - testlib - test - - - junit - junit - test - - - org.mockito - mockito-all - test - - - com.google.truth - truth - test - - - - com.google.api - gax-grpc - testlib - test - - - io.grpc - grpc-testing - test + google-cloud-bigtable - - - - org.apache.maven.plugins - maven-failsafe-plugin - 2.19.1 - - - - integration-test - verify - - - - - classes - true - 2 - - - - org.apache.maven.surefire - surefire-junit4 - 2.19.1 - - - - - maven-surefire-plugin - 2.19.1 - - - org.apache.maven.surefire - surefire-junit4 - 2.19.1 - - - - - diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/internal/DeprecationMarker.java b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/internal/DeprecationMarker.java new file mode 100644 index 000000000000..fd1e724d123c --- /dev/null +++ b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/internal/DeprecationMarker.java @@ -0,0 +1,28 @@ +/* + * Copyright 2019 Google LLC + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.google.cloud.bigtable.admin.v2.internal; + +/** + * Marker class whose existence can be used to detect uses of the deprecated + * google-cloud-bigtable-admin artifact + * + *

This class is considered an internal implementation detail and not meant to be used by + * applications. + * + * @deprecated Please migrate to using the google-cloud-bigtable artifact + */ +@Deprecated +public final class DeprecationMarker {} diff --git a/google-cloud-clients/google-cloud-bigtable-admin/synth.metadata b/google-cloud-clients/google-cloud-bigtable-admin/synth.metadata deleted file mode 100644 index 2bd4f07a69a5..000000000000 --- a/google-cloud-clients/google-cloud-bigtable-admin/synth.metadata +++ /dev/null @@ -1,27 +0,0 @@ -{ - "sources": [ - { - "git": { - "name": "googleapis", - "remote": "https://github.com/googleapis/googleapis.git", - "sha": "5a57f0c13a358b2b15452bf2d67453774a5f6d4f", - "internalRef": "221837528" - } - }, - { - "git": { - "name": "googleapis-private", - "remote": "https://github.com/googleapis/googleapis-private.git", - "sha": "6aa8e1a447bb8d0367150356a28cb4d3f2332641", - "internalRef": "221340946" - } - }, - { - "generator": { - "name": "artman", - "version": "0.16.0", - "dockerImage": "googleapis/artman@sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b" - } - } - ] -} diff --git a/google-cloud-clients/google-cloud-bigtable-admin/synth.py b/google-cloud-clients/google-cloud-bigtable-admin/synth.py deleted file mode 100644 index 7ac3b5755f63..000000000000 --- a/google-cloud-clients/google-cloud-bigtable-admin/synth.py +++ /dev/null @@ -1,40 +0,0 @@ -# Copyright 2018 Google LLC -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -"""This script is used to synthesize generated parts of this library.""" - -import synthtool as s -import synthtool.gcp as gcp -import synthtool.languages.java as java - -gapic = gcp.GAPICGenerator() - -service = 'bigtable-admin' -versions = ['v2'] -config_pattern = '/google/bigtable/admin/artman_bigtableadmin.yaml' - -for version in versions: - library = gapic.java_library( - service=service, - version=version, - config_path=config_pattern.format(version=version), - artman_output_name='') - - s.copy(library / f'gapic-google-cloud-{service}-{version}/src', 'src') - s.copy(library / f'grpc-google-cloud-{service}-{version}/src', f'../../google-api-grpc/grpc-google-cloud-{service}-{version}/src') - s.copy(library / f'proto-google-cloud-{service}-{version}/src', f'../../google-api-grpc/proto-google-cloud-{service}-{version}/src') - - java.format_code('./src') - java.format_code(f'../../google-api-grpc/grpc-google-cloud-{service}-{version}/src') - java.format_code(f'../../google-api-grpc/proto-google-cloud-{service}-{version}/src') diff --git a/google-cloud-clients/google-cloud-bigtable/README.md b/google-cloud-clients/google-cloud-bigtable/README.md index 1fff53b41f57..125293844e57 100644 --- a/google-cloud-clients/google-cloud-bigtable/README.md +++ b/google-cloud-clients/google-cloud-bigtable/README.md @@ -107,10 +107,10 @@ The Admin APIs are similar. Here is a code snippet showing how to create a table imports at the top of your file: ```java -import com.google.bigtable.admin.v2.ColumnFamily; -import com.google.bigtable.admin.v2.InstanceName; -import com.google.bigtable.admin.v2.Table; +import static com.google.cloud.bigtable.admin.v2.models.GCRules.GCRULES; import com.google.cloud.bigtable.admin.v2.BigtableTableAdminClient; +import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest; +import com.google.cloud.bigtable.admin.v2.models.Table; ``` Then, to create a table, use the following code: @@ -118,15 +118,13 @@ Then, to create a table, use the following code: String projectId = "my-instance"; String instanceId = "my-database"; -BigtableTableAdminClient tableAdminClient = BigtableTableAdminClient.create(); +BigtableTableAdminClient tableAdminClient = BigtableTableAdminClient + .create(projectId, instanceId); try { tableAdminClient.createTable( - InstanceName.of(projectId, instanceId), - "new-table-id", - Table.newBuilder() - .putColumnFamilies("my-family", ColumnFamily.getDefaultInstance()) - .build() + CreateTableRequest.of("my-table") + .addFamily("my-family") ); } finally { tableAdminClient.close(); diff --git a/google-cloud-clients/google-cloud-bigtable/pom.xml b/google-cloud-clients/google-cloud-bigtable/pom.xml index 63ae5d460919..c6fdad0327cc 100644 --- a/google-cloud-clients/google-cloud-bigtable/pom.xml +++ b/google-cloud-clients/google-cloud-bigtable/pom.xml @@ -79,6 +79,12 @@ truth test + + com.google.api + gax + testlib + test + com.google.api diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminSettings.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminSettings.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminSettings.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminSettings.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java similarity index 99% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java index 25005f1ed0aa..909bc13132ca 100644 --- a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java @@ -52,6 +52,7 @@ import com.google.bigtable.admin.v2.SnapshotTableRequest; import com.google.bigtable.admin.v2.Table; import com.google.bigtable.admin.v2.TableName; +import com.google.cloud.bigtable.admin.v2.internal.ArtifactDeprecationChecker; import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStub; import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStubSettings; import com.google.longrunning.Operation; @@ -140,6 +141,10 @@ public class BaseBigtableTableAdminClient implements BackgroundResource { private final BigtableTableAdminStub stub; private final OperationsClient operationsClient; + static { + ArtifactDeprecationChecker.checkDeprecatedArtifactUse(); + } + /** Constructs an instance of BaseBigtableTableAdminClient with default settings. */ public static final BaseBigtableTableAdminClient create() throws IOException { return create(BaseBigtableTableAdminSettings.newBuilder().build()); diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java similarity index 99% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java index 7c673bae7b1d..f136ef5de67e 100644 --- a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java @@ -29,6 +29,7 @@ import com.google.cloud.Policy.DefaultMarshaller; import com.google.cloud.bigtable.admin.v2.BaseBigtableInstanceAdminClient.ListAppProfilesPage; import com.google.cloud.bigtable.admin.v2.BaseBigtableInstanceAdminClient.ListAppProfilesPagedResponse; +import com.google.cloud.bigtable.admin.v2.internal.ArtifactDeprecationChecker; import com.google.cloud.bigtable.admin.v2.internal.NameUtil; import com.google.cloud.bigtable.admin.v2.models.AppProfile; import com.google.cloud.bigtable.admin.v2.models.Cluster; @@ -53,6 +54,7 @@ import java.io.IOException; import java.util.Arrays; import java.util.List; +import java.util.logging.Logger; import javax.annotation.Nonnull; /** @@ -99,10 +101,13 @@ * } */ public final class BigtableInstanceAdminClient implements AutoCloseable { - private final String projectId; private final BigtableInstanceAdminStub stub; + static { + ArtifactDeprecationChecker.checkDeprecatedArtifactUse(); + } + /** Constructs an instance of BigtableInstanceAdminClient with the given project id. */ public static BigtableInstanceAdminClient create(@Nonnull String projectId) throws IOException { return create(BigtableInstanceAdminSettings.newBuilder().setProjectId(projectId).build()); diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettings.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettings.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettings.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettings.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettings.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettings.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettings.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettings.java diff --git a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/internal/ArtifactDeprecationChecker.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/internal/ArtifactDeprecationChecker.java new file mode 100644 index 000000000000..ff239d13cd26 --- /dev/null +++ b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/internal/ArtifactDeprecationChecker.java @@ -0,0 +1,51 @@ +/* + * Copyright 2019 Google LLC + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.google.cloud.bigtable.admin.v2.internal; + +import com.google.api.core.InternalApi; +import java.util.logging.Logger; + +/** + * This class detects usage of and notifies users that the google-cloud-bigtable-admin artifact has + * been deprecated in favor of the merged google-cloud-bigtable artifact. + * + *

This class is considered an internal implementation detail and not meant to be used by + * applications. + */ +@InternalApi +public final class ArtifactDeprecationChecker { + private static final Logger LOGGER = Logger.getLogger(ArtifactDeprecationChecker.class.getName()); + + public static void checkDeprecatedArtifactUse() { + if (isDeprecationMarkerPresent()) { + LOGGER.warning( + "google-cloud-bigtable-admin has been merged into google-cloud-bigtable." + + " Please update your build file to stop depending on google-cloud-bigtable-admin" + + " and use google-cloud-bigtable directly."); + } + } + + private static boolean isDeprecationMarkerPresent() { + try { + ArtifactDeprecationChecker.class + .getClassLoader() + .loadClass("com.google.cloud.bigtable.admin.v2.internal.DeprecationMarker"); + return true; + } catch (ClassNotFoundException e) { + return false; + } + } +} diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/internal/NameUtil.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/internal/NameUtil.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/internal/NameUtil.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/internal/NameUtil.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/AppProfile.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/AppProfile.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/AppProfile.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/AppProfile.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/Cluster.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Cluster.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/Cluster.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Cluster.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/ColumnFamily.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ColumnFamily.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/ColumnFamily.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ColumnFamily.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequest.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequest.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequest.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequest.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateInstanceRequest.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateInstanceRequest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateInstanceRequest.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateInstanceRequest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateTableRequest.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateTableRequest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateTableRequest.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateTableRequest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/GCRules.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/GCRules.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/GCRules.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/GCRules.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/Instance.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Instance.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/Instance.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Instance.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/ModifyColumnFamiliesRequest.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ModifyColumnFamiliesRequest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/ModifyColumnFamiliesRequest.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ModifyColumnFamiliesRequest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListClustersException.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListClustersException.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListClustersException.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListClustersException.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListInstancesException.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListInstancesException.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListInstancesException.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/PartialListInstancesException.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/StorageType.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/StorageType.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/StorageType.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/StorageType.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/Table.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Table.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/Table.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Table.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequest.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequest.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/package-info.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/package-info.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/package-info.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/package-info.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallable.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallable.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallable.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallable.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStub.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStub.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStub.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStub.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminCallableFactory.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminCallableFactory.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminCallableFactory.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminCallableFactory.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminStub.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminStub.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminStub.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminStub.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminCallableFactory.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminCallableFactory.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminCallableFactory.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminCallableFactory.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java rename to google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClientTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClientTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClientTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClientTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClientTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClientTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClientTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClientTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClientTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClientTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClientTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClientTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettingsTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettingsTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettingsTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettingsTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettingsTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettingsTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettingsTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettingsTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdmin.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdmin.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdmin.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdmin.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdminImpl.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdminImpl.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdminImpl.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableInstanceAdminImpl.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdmin.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdmin.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdmin.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdmin.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/AppProfileTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/AppProfileTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/AppProfileTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/AppProfileTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/ClusterTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/ClusterTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/ClusterTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/ClusterTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequestTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequestTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequestTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateAppProfileRequestTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequestTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequestTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequestTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequestTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/GCRulesTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/GCRulesTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/GCRulesTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/GCRulesTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/InstanceTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/InstanceTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/InstanceTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/InstanceTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/StorageTypeTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/StorageTypeTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/StorageTypeTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/StorageTypeTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequestTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequestTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequestTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequestTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequestTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequestTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequestTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/UpdateInstanceRequestTest.java diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallableTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallableTest.java similarity index 100% rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallableTest.java rename to google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallableTest.java diff --git a/google-cloud-clients/google-cloud-bigtable/synth.py b/google-cloud-clients/google-cloud-bigtable/synth.py index 132233132df1..bedb87048dd9 100644 --- a/google-cloud-clients/google-cloud-bigtable/synth.py +++ b/google-cloud-clients/google-cloud-bigtable/synth.py @@ -20,21 +20,38 @@ gapic = gcp.GAPICGenerator() -service = 'bigtable' -versions = ['v2'] -config_pattern = '/google/bigtable/artman_bigtable.yaml' - -for version in versions: - library = gapic.java_library( - service=service, - version=version, - config_path=config_pattern.format(version=version), - artman_output_name='') - - s.copy(library / f'gapic-google-cloud-{service}-{version}/src', 'src') - s.copy(library / f'grpc-google-cloud-{service}-{version}/src', f'../../google-api-grpc/grpc-google-cloud-{service}-{version}/src') - s.copy(library / f'proto-google-cloud-{service}-{version}/src', f'../../google-api-grpc/proto-google-cloud-{service}-{version}/src') - - java.format_code('./src') - java.format_code(f'../../google-api-grpc/grpc-google-cloud-{service}-{version}/src') - java.format_code(f'../../google-api-grpc/proto-google-cloud-{service}-{version}/src') +excludes = [ + 'src/main/java/com/google/cloud/bigtable/data/v2/package-info.java', + 'src/main/java/com/google/cloud/bigtable/admin/v2/package-info.java', +] + +data_library = gapic.java_library( + service='bigtable', + version='v2', + config_path='/google/bigtable/artman_bigtable.yaml', + artman_output_name='') + + +s.copy(data_library / 'gapic-google-cloud-{service}-{version}/src', 'src') +s.copy(data_library / 'grpc-google-cloud-{service}-{version}/src', '../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') +s.copy(data_library / 'proto-google-cloud-{service}-{version}/src', '../../google-api-grpc/proto-google-cloud-bigtable-v2/src', excludes=excludes) + +java.format_code('./src') +java.format_code('../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') +java.format_code('../../google-api-grpc/proto-google-cloud-bigtable-v2/src') + + +admin_library = gapic.java_library( + service='bigtable', + version='v2', + config_path='/google/bigtable/artman_bigtable.yaml', + artman_output_name='') + + +s.copy(admin_library / 'gapic-google-cloud-bigtable-admin-v2/src', 'src') +s.copy(admin_library / 'grpc-google-cloud-bigtable-admin-v2/src', '../../google-api-grpc/grpc-google-cloud-bigtable-admin-v2/src') +s.copy(admin_library / 'proto-google-cloud-bigtable-admin-v2/src', '../../google-api-grpc/proto-google-cloud-bigtable-admin-v2/src', excludes=excludes) + +java.format_code('./src') +java.format_code('../../google-api-grpc/grpc-google-cloud-bigtable-admin-v2/src') +java.format_code('../../google-api-grpc/proto-google-cloud-bigtable-admin-v2/src') From cc2b9e86b872e793c17a47caca4d2789febb2a72 Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 12:43:56 -0500 Subject: [PATCH 02/13] split exclusion change for future PR --- google-cloud-clients/google-cloud-bigtable/synth.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable/synth.py b/google-cloud-clients/google-cloud-bigtable/synth.py index bedb87048dd9..5ca32bd3c540 100644 --- a/google-cloud-clients/google-cloud-bigtable/synth.py +++ b/google-cloud-clients/google-cloud-bigtable/synth.py @@ -20,11 +20,6 @@ gapic = gcp.GAPICGenerator() -excludes = [ - 'src/main/java/com/google/cloud/bigtable/data/v2/package-info.java', - 'src/main/java/com/google/cloud/bigtable/admin/v2/package-info.java', -] - data_library = gapic.java_library( service='bigtable', version='v2', @@ -34,7 +29,7 @@ s.copy(data_library / 'gapic-google-cloud-{service}-{version}/src', 'src') s.copy(data_library / 'grpc-google-cloud-{service}-{version}/src', '../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') -s.copy(data_library / 'proto-google-cloud-{service}-{version}/src', '../../google-api-grpc/proto-google-cloud-bigtable-v2/src', excludes=excludes) +s.copy(data_library / 'proto-google-cloud-{service}-{version}/src', '../../google-api-grpc/proto-google-cloud-bigtable-v2/src') java.format_code('./src') java.format_code('../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') @@ -50,7 +45,7 @@ s.copy(admin_library / 'gapic-google-cloud-bigtable-admin-v2/src', 'src') s.copy(admin_library / 'grpc-google-cloud-bigtable-admin-v2/src', '../../google-api-grpc/grpc-google-cloud-bigtable-admin-v2/src') -s.copy(admin_library / 'proto-google-cloud-bigtable-admin-v2/src', '../../google-api-grpc/proto-google-cloud-bigtable-admin-v2/src', excludes=excludes) +s.copy(admin_library / 'proto-google-cloud-bigtable-admin-v2/src', '../../google-api-grpc/proto-google-cloud-bigtable-admin-v2/src') java.format_code('./src') java.format_code('../../google-api-grpc/grpc-google-cloud-bigtable-admin-v2/src') From e6cbacc18d9816bc91fe1611bd408a39f557420b Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 12:45:03 -0500 Subject: [PATCH 03/13] fix admin pathes --- google-cloud-clients/google-cloud-bigtable/synth.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable/synth.py b/google-cloud-clients/google-cloud-bigtable/synth.py index 5ca32bd3c540..e8c61d53c9c9 100644 --- a/google-cloud-clients/google-cloud-bigtable/synth.py +++ b/google-cloud-clients/google-cloud-bigtable/synth.py @@ -37,9 +37,9 @@ admin_library = gapic.java_library( - service='bigtable', + service='bigtable-admin', version='v2', - config_path='/google/bigtable/artman_bigtable.yaml', + config_path='/google/bigtable/admin/artman_bigtableadmin.yaml', artman_output_name='') From a385e8a6e31f4a447e950f51d4d647cfe38fa42f Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 13:06:47 -0500 Subject: [PATCH 04/13] fix deprecation warning --- .../bigtable/admin/v2/BaseBigtableTableAdminClient.java | 5 ----- .../bigtable/admin/v2/BigtableInstanceAdminClient.java | 7 +++---- .../cloud/bigtable/admin/v2/BigtableTableAdminClient.java | 5 +++++ 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java index 909bc13132ca..25005f1ed0aa 100644 --- a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java @@ -52,7 +52,6 @@ import com.google.bigtable.admin.v2.SnapshotTableRequest; import com.google.bigtable.admin.v2.Table; import com.google.bigtable.admin.v2.TableName; -import com.google.cloud.bigtable.admin.v2.internal.ArtifactDeprecationChecker; import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStub; import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStubSettings; import com.google.longrunning.Operation; @@ -141,10 +140,6 @@ public class BaseBigtableTableAdminClient implements BackgroundResource { private final BigtableTableAdminStub stub; private final OperationsClient operationsClient; - static { - ArtifactDeprecationChecker.checkDeprecatedArtifactUse(); - } - /** Constructs an instance of BaseBigtableTableAdminClient with default settings. */ public static final BaseBigtableTableAdminClient create() throws IOException { return create(BaseBigtableTableAdminSettings.newBuilder().build()); diff --git a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java index f136ef5de67e..94d05f97ac72 100644 --- a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java @@ -54,7 +54,6 @@ import java.io.IOException; import java.util.Arrays; import java.util.List; -import java.util.logging.Logger; import javax.annotation.Nonnull; /** @@ -101,13 +100,13 @@ * } */ public final class BigtableInstanceAdminClient implements AutoCloseable { - private final String projectId; - private final BigtableInstanceAdminStub stub; - static { ArtifactDeprecationChecker.checkDeprecatedArtifactUse(); } + private final String projectId; + private final BigtableInstanceAdminStub stub; + /** Constructs an instance of BigtableInstanceAdminClient with the given project id. */ public static BigtableInstanceAdminClient create(@Nonnull String projectId) throws IOException { return create(BigtableInstanceAdminSettings.newBuilder().setProjectId(projectId).build()); diff --git a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java index c4d3b88314f9..8f5185a19396 100644 --- a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java @@ -27,6 +27,7 @@ import com.google.bigtable.admin.v2.ListTablesRequest; import com.google.cloud.bigtable.admin.v2.BaseBigtableTableAdminClient.ListTablesPage; import com.google.cloud.bigtable.admin.v2.BaseBigtableTableAdminClient.ListTablesPagedResponse; +import com.google.cloud.bigtable.admin.v2.internal.ArtifactDeprecationChecker; import com.google.cloud.bigtable.admin.v2.internal.NameUtil; import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest; import com.google.cloud.bigtable.admin.v2.models.ModifyColumnFamiliesRequest; @@ -94,6 +95,10 @@ */ public final class BigtableTableAdminClient implements AutoCloseable { + static { + ArtifactDeprecationChecker.checkDeprecatedArtifactUse(); + } + private final EnhancedBigtableTableAdminStub stub; private final String projectId; private final String instanceId; From a618c24cac8b61e5bc53ed838596b079afb27194 Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 13:07:00 -0500 Subject: [PATCH 05/13] fix synth script --- google-cloud-clients/google-cloud-bigtable/synth.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable/synth.py b/google-cloud-clients/google-cloud-bigtable/synth.py index e8c61d53c9c9..c2a6145cf2ba 100644 --- a/google-cloud-clients/google-cloud-bigtable/synth.py +++ b/google-cloud-clients/google-cloud-bigtable/synth.py @@ -27,9 +27,9 @@ artman_output_name='') -s.copy(data_library / 'gapic-google-cloud-{service}-{version}/src', 'src') -s.copy(data_library / 'grpc-google-cloud-{service}-{version}/src', '../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') -s.copy(data_library / 'proto-google-cloud-{service}-{version}/src', '../../google-api-grpc/proto-google-cloud-bigtable-v2/src') +s.copy(data_library / 'gapic-google-cloud-bigtable-v2/src', 'src') +s.copy(data_library / 'grpc-google-cloud-bigtable-v2/src', '../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') +s.copy(data_library / 'proto-google-cloud-bigtable-v2/src', '../../google-api-grpc/proto-google-cloud-bigtable-v2/src') java.format_code('./src') java.format_code('../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') From 2f2e984fbac87ba8fd321038e19b1f4a95b9adc3 Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 13:08:22 -0500 Subject: [PATCH 06/13] fix generated file --- .../data/v2/BaseBigtableDataClientTest.java | 52 +++++++++++-------- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java index 0b55cb6ed4b0..8fa5813be340 100644 --- a/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java +++ b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java @@ -40,7 +40,7 @@ import com.google.bigtable.v2.RowFilter; import com.google.bigtable.v2.SampleRowKeysRequest; import com.google.bigtable.v2.SampleRowKeysResponse; -import com.google.cloud.bigtable.data.v2.internal.NameUtil; +import com.google.bigtable.v2.TableName; import com.google.protobuf.ByteString; import com.google.protobuf.GeneratedMessageV3; import io.grpc.Status; @@ -101,8 +101,9 @@ public void readRowsTest() throws Exception { ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setLastScannedRowKey(lastScannedRowKey).build(); mockBigtable.addResponse(expectedResponse); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); - ReadRowsRequest request = ReadRowsRequest.newBuilder().setTableName(tableName).build(); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + ReadRowsRequest request = + ReadRowsRequest.newBuilder().setTableName(tableName.toString()).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -119,8 +120,9 @@ public void readRowsTest() throws Exception { public void readRowsExceptionTest() throws Exception { StatusRuntimeException exception = new StatusRuntimeException(Status.INVALID_ARGUMENT); mockBigtable.addException(exception); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); - ReadRowsRequest request = ReadRowsRequest.newBuilder().setTableName(tableName).build(); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + ReadRowsRequest request = + ReadRowsRequest.newBuilder().setTableName(tableName.toString()).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -145,9 +147,9 @@ public void sampleRowKeysTest() throws Exception { SampleRowKeysResponse expectedResponse = SampleRowKeysResponse.newBuilder().setRowKey(rowKey).setOffsetBytes(offsetBytes).build(); mockBigtable.addResponse(expectedResponse); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); SampleRowKeysRequest request = - SampleRowKeysRequest.newBuilder().setTableName(tableName).build(); + SampleRowKeysRequest.newBuilder().setTableName(tableName.toString()).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -165,9 +167,9 @@ public void sampleRowKeysTest() throws Exception { public void sampleRowKeysExceptionTest() throws Exception { StatusRuntimeException exception = new StatusRuntimeException(Status.INVALID_ARGUMENT); mockBigtable.addException(exception); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); SampleRowKeysRequest request = - SampleRowKeysRequest.newBuilder().setTableName(tableName).build(); + SampleRowKeysRequest.newBuilder().setTableName(tableName.toString()).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -191,7 +193,7 @@ public void mutateRowTest() { MutateRowResponse expectedResponse = MutateRowResponse.newBuilder().build(); mockBigtable.addResponse(expectedResponse); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List mutations = new ArrayList<>(); @@ -202,7 +204,7 @@ public void mutateRowTest() { Assert.assertEquals(1, actualRequests.size()); MutateRowRequest actualRequest = (MutateRowRequest) actualRequests.get(0); - Assert.assertEquals(tableName, actualRequest.getTableName()); + Assert.assertEquals(tableName, TableName.parse(actualRequest.getTableName())); Assert.assertEquals(rowKey, actualRequest.getRowKey()); Assert.assertEquals(mutations, actualRequest.getMutationsList()); Assert.assertTrue( @@ -218,7 +220,7 @@ public void mutateRowExceptionTest() throws Exception { mockBigtable.addException(exception); try { - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List mutations = new ArrayList<>(); @@ -234,10 +236,13 @@ public void mutateRowExceptionTest() throws Exception { public void mutateRowsTest() throws Exception { MutateRowsResponse expectedResponse = MutateRowsResponse.newBuilder().build(); mockBigtable.addResponse(expectedResponse); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); List entries = new ArrayList<>(); MutateRowsRequest request = - MutateRowsRequest.newBuilder().setTableName(tableName).addAllEntries(entries).build(); + MutateRowsRequest.newBuilder() + .setTableName(tableName.toString()) + .addAllEntries(entries) + .build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -255,10 +260,13 @@ public void mutateRowsTest() throws Exception { public void mutateRowsExceptionTest() throws Exception { StatusRuntimeException exception = new StatusRuntimeException(Status.INVALID_ARGUMENT); mockBigtable.addException(exception); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); List entries = new ArrayList<>(); MutateRowsRequest request = - MutateRowsRequest.newBuilder().setTableName(tableName).addAllEntries(entries).build(); + MutateRowsRequest.newBuilder() + .setTableName(tableName.toString()) + .addAllEntries(entries) + .build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -284,7 +292,7 @@ public void checkAndMutateRowTest() { CheckAndMutateRowResponse.newBuilder().setPredicateMatched(predicateMatched).build(); mockBigtable.addResponse(expectedResponse); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); RowFilter predicateFilter = RowFilter.newBuilder().build(); List trueMutations = new ArrayList<>(); @@ -298,7 +306,7 @@ public void checkAndMutateRowTest() { Assert.assertEquals(1, actualRequests.size()); CheckAndMutateRowRequest actualRequest = (CheckAndMutateRowRequest) actualRequests.get(0); - Assert.assertEquals(tableName, actualRequest.getTableName()); + Assert.assertEquals(tableName, TableName.parse(actualRequest.getTableName())); Assert.assertEquals(rowKey, actualRequest.getRowKey()); Assert.assertEquals(predicateFilter, actualRequest.getPredicateFilter()); Assert.assertEquals(trueMutations, actualRequest.getTrueMutationsList()); @@ -316,7 +324,7 @@ public void checkAndMutateRowExceptionTest() throws Exception { mockBigtable.addException(exception); try { - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); RowFilter predicateFilter = RowFilter.newBuilder().build(); List trueMutations = new ArrayList<>(); @@ -335,7 +343,7 @@ public void readModifyWriteRowTest() { ReadModifyWriteRowResponse expectedResponse = ReadModifyWriteRowResponse.newBuilder().build(); mockBigtable.addResponse(expectedResponse); - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List rules = new ArrayList<>(); @@ -346,7 +354,7 @@ public void readModifyWriteRowTest() { Assert.assertEquals(1, actualRequests.size()); ReadModifyWriteRowRequest actualRequest = (ReadModifyWriteRowRequest) actualRequests.get(0); - Assert.assertEquals(tableName, actualRequest.getTableName()); + Assert.assertEquals(tableName, TableName.parse(actualRequest.getTableName())); Assert.assertEquals(rowKey, actualRequest.getRowKey()); Assert.assertEquals(rules, actualRequest.getRulesList()); Assert.assertTrue( @@ -362,7 +370,7 @@ public void readModifyWriteRowExceptionTest() throws Exception { mockBigtable.addException(exception); try { - String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List rules = new ArrayList<>(); From 9cce259be722508dd988d45b1cea3788ec9623d4 Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 13:09:58 -0500 Subject: [PATCH 07/13] temporarily re-add kokoro scripts (and point them to the merged artifact) until the jobs have been removed --- .kokoro/continuous/bigtableadmin-it.cfg | 27 +++++++++++++++++++++++++ .kokoro/nightly/bigtableadmin-it.cfg | 27 +++++++++++++++++++++++++ .kokoro/presubmit/bigtableadmin-it.cfg | 27 +++++++++++++++++++++++++ 3 files changed, 81 insertions(+) create mode 100644 .kokoro/continuous/bigtableadmin-it.cfg create mode 100644 .kokoro/nightly/bigtableadmin-it.cfg create mode 100644 .kokoro/presubmit/bigtableadmin-it.cfg diff --git a/.kokoro/continuous/bigtableadmin-it.cfg b/.kokoro/continuous/bigtableadmin-it.cfg new file mode 100644 index 000000000000..574d996fc0e9 --- /dev/null +++ b/.kokoro/continuous/bigtableadmin-it.cfg @@ -0,0 +1,27 @@ +# Format: //devtools/kokoro/config/proto/build.proto + +# Configure the docker image for kokoro-trampoline. +env_vars: { + key: "TRAMPOLINE_IMAGE" + value: "gcr.io/cloud-devrel-kokoro-resources/java8" +} + +env_vars: { + key: "INTEGRATION_TEST_ARGS" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" +} + +env_vars: { + key: "JOB_TYPE" + value: "integration" +} + +env_vars: { + key: "GCLOUD_PROJECT" + value: "gcloud-devel" +} + +env_vars: { + key: "GOOGLE_APPLICATION_CREDENTIALS" + value: "keystore/73713_java_it_service_account" +} diff --git a/.kokoro/nightly/bigtableadmin-it.cfg b/.kokoro/nightly/bigtableadmin-it.cfg new file mode 100644 index 000000000000..574d996fc0e9 --- /dev/null +++ b/.kokoro/nightly/bigtableadmin-it.cfg @@ -0,0 +1,27 @@ +# Format: //devtools/kokoro/config/proto/build.proto + +# Configure the docker image for kokoro-trampoline. +env_vars: { + key: "TRAMPOLINE_IMAGE" + value: "gcr.io/cloud-devrel-kokoro-resources/java8" +} + +env_vars: { + key: "INTEGRATION_TEST_ARGS" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" +} + +env_vars: { + key: "JOB_TYPE" + value: "integration" +} + +env_vars: { + key: "GCLOUD_PROJECT" + value: "gcloud-devel" +} + +env_vars: { + key: "GOOGLE_APPLICATION_CREDENTIALS" + value: "keystore/73713_java_it_service_account" +} diff --git a/.kokoro/presubmit/bigtableadmin-it.cfg b/.kokoro/presubmit/bigtableadmin-it.cfg new file mode 100644 index 000000000000..574d996fc0e9 --- /dev/null +++ b/.kokoro/presubmit/bigtableadmin-it.cfg @@ -0,0 +1,27 @@ +# Format: //devtools/kokoro/config/proto/build.proto + +# Configure the docker image for kokoro-trampoline. +env_vars: { + key: "TRAMPOLINE_IMAGE" + value: "gcr.io/cloud-devrel-kokoro-resources/java8" +} + +env_vars: { + key: "INTEGRATION_TEST_ARGS" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" +} + +env_vars: { + key: "JOB_TYPE" + value: "integration" +} + +env_vars: { + key: "GCLOUD_PROJECT" + value: "gcloud-devel" +} + +env_vars: { + key: "GOOGLE_APPLICATION_CREDENTIALS" + value: "keystore/73713_java_it_service_account" +} From de993799bc321517a1a8c7ce80cf5ce19a929659 Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 13:21:50 -0500 Subject: [PATCH 08/13] Remove dep from examples --- google-cloud-examples/pom.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/google-cloud-examples/pom.xml b/google-cloud-examples/pom.xml index ada6587b8e3f..a96ce675a5f2 100644 --- a/google-cloud-examples/pom.xml +++ b/google-cloud-examples/pom.xml @@ -29,10 +29,6 @@ com.google.cloud google-cloud-bigquery - - com.google.cloud - google-cloud-bigtable-admin - com.google.cloud google-cloud-bigtable From 2c1c5a5ec6d9f01b259ba880e9ea28765b58cbfd Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 14:02:04 -0500 Subject: [PATCH 09/13] fix admin integration tests --- .kokoro/continuous/bigtableadmin-it.cfg | 2 +- .kokoro/nightly/bigtableadmin-it.cfg | 2 +- .kokoro/presubmit/bigtableadmin-it.cfg | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.kokoro/continuous/bigtableadmin-it.cfg b/.kokoro/continuous/bigtableadmin-it.cfg index 574d996fc0e9..6694f4ba9189 100644 --- a/.kokoro/continuous/bigtableadmin-it.cfg +++ b/.kokoro/continuous/bigtableadmin-it.cfg @@ -8,7 +8,7 @@ env_vars: { env_vars: { key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" } env_vars: { diff --git a/.kokoro/nightly/bigtableadmin-it.cfg b/.kokoro/nightly/bigtableadmin-it.cfg index 574d996fc0e9..6694f4ba9189 100644 --- a/.kokoro/nightly/bigtableadmin-it.cfg +++ b/.kokoro/nightly/bigtableadmin-it.cfg @@ -8,7 +8,7 @@ env_vars: { env_vars: { key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" } env_vars: { diff --git a/.kokoro/presubmit/bigtableadmin-it.cfg b/.kokoro/presubmit/bigtableadmin-it.cfg index 574d996fc0e9..6694f4ba9189 100644 --- a/.kokoro/presubmit/bigtableadmin-it.cfg +++ b/.kokoro/presubmit/bigtableadmin-it.cfg @@ -8,7 +8,7 @@ env_vars: { env_vars: { key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" } env_vars: { From 98d2e71ea7cb098b58e53e67dab00aca0d478ddf Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 14:05:43 -0500 Subject: [PATCH 10/13] revert stray fix (will be added to a separate PR) --- .../data/v2/BaseBigtableDataClientTest.java | 52 ++++++++----------- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java index 8fa5813be340..0b55cb6ed4b0 100644 --- a/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java +++ b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BaseBigtableDataClientTest.java @@ -40,7 +40,7 @@ import com.google.bigtable.v2.RowFilter; import com.google.bigtable.v2.SampleRowKeysRequest; import com.google.bigtable.v2.SampleRowKeysResponse; -import com.google.bigtable.v2.TableName; +import com.google.cloud.bigtable.data.v2.internal.NameUtil; import com.google.protobuf.ByteString; import com.google.protobuf.GeneratedMessageV3; import io.grpc.Status; @@ -101,9 +101,8 @@ public void readRowsTest() throws Exception { ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setLastScannedRowKey(lastScannedRowKey).build(); mockBigtable.addResponse(expectedResponse); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); - ReadRowsRequest request = - ReadRowsRequest.newBuilder().setTableName(tableName.toString()).build(); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + ReadRowsRequest request = ReadRowsRequest.newBuilder().setTableName(tableName).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -120,9 +119,8 @@ public void readRowsTest() throws Exception { public void readRowsExceptionTest() throws Exception { StatusRuntimeException exception = new StatusRuntimeException(Status.INVALID_ARGUMENT); mockBigtable.addException(exception); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); - ReadRowsRequest request = - ReadRowsRequest.newBuilder().setTableName(tableName.toString()).build(); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); + ReadRowsRequest request = ReadRowsRequest.newBuilder().setTableName(tableName).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -147,9 +145,9 @@ public void sampleRowKeysTest() throws Exception { SampleRowKeysResponse expectedResponse = SampleRowKeysResponse.newBuilder().setRowKey(rowKey).setOffsetBytes(offsetBytes).build(); mockBigtable.addResponse(expectedResponse); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); SampleRowKeysRequest request = - SampleRowKeysRequest.newBuilder().setTableName(tableName.toString()).build(); + SampleRowKeysRequest.newBuilder().setTableName(tableName).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -167,9 +165,9 @@ public void sampleRowKeysTest() throws Exception { public void sampleRowKeysExceptionTest() throws Exception { StatusRuntimeException exception = new StatusRuntimeException(Status.INVALID_ARGUMENT); mockBigtable.addException(exception); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); SampleRowKeysRequest request = - SampleRowKeysRequest.newBuilder().setTableName(tableName.toString()).build(); + SampleRowKeysRequest.newBuilder().setTableName(tableName).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -193,7 +191,7 @@ public void mutateRowTest() { MutateRowResponse expectedResponse = MutateRowResponse.newBuilder().build(); mockBigtable.addResponse(expectedResponse); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List mutations = new ArrayList<>(); @@ -204,7 +202,7 @@ public void mutateRowTest() { Assert.assertEquals(1, actualRequests.size()); MutateRowRequest actualRequest = (MutateRowRequest) actualRequests.get(0); - Assert.assertEquals(tableName, TableName.parse(actualRequest.getTableName())); + Assert.assertEquals(tableName, actualRequest.getTableName()); Assert.assertEquals(rowKey, actualRequest.getRowKey()); Assert.assertEquals(mutations, actualRequest.getMutationsList()); Assert.assertTrue( @@ -220,7 +218,7 @@ public void mutateRowExceptionTest() throws Exception { mockBigtable.addException(exception); try { - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List mutations = new ArrayList<>(); @@ -236,13 +234,10 @@ public void mutateRowExceptionTest() throws Exception { public void mutateRowsTest() throws Exception { MutateRowsResponse expectedResponse = MutateRowsResponse.newBuilder().build(); mockBigtable.addResponse(expectedResponse); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); List entries = new ArrayList<>(); MutateRowsRequest request = - MutateRowsRequest.newBuilder() - .setTableName(tableName.toString()) - .addAllEntries(entries) - .build(); + MutateRowsRequest.newBuilder().setTableName(tableName).addAllEntries(entries).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -260,13 +255,10 @@ public void mutateRowsTest() throws Exception { public void mutateRowsExceptionTest() throws Exception { StatusRuntimeException exception = new StatusRuntimeException(Status.INVALID_ARGUMENT); mockBigtable.addException(exception); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); List entries = new ArrayList<>(); MutateRowsRequest request = - MutateRowsRequest.newBuilder() - .setTableName(tableName.toString()) - .addAllEntries(entries) - .build(); + MutateRowsRequest.newBuilder().setTableName(tableName).addAllEntries(entries).build(); MockStreamObserver responseObserver = new MockStreamObserver<>(); @@ -292,7 +284,7 @@ public void checkAndMutateRowTest() { CheckAndMutateRowResponse.newBuilder().setPredicateMatched(predicateMatched).build(); mockBigtable.addResponse(expectedResponse); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); RowFilter predicateFilter = RowFilter.newBuilder().build(); List trueMutations = new ArrayList<>(); @@ -306,7 +298,7 @@ public void checkAndMutateRowTest() { Assert.assertEquals(1, actualRequests.size()); CheckAndMutateRowRequest actualRequest = (CheckAndMutateRowRequest) actualRequests.get(0); - Assert.assertEquals(tableName, TableName.parse(actualRequest.getTableName())); + Assert.assertEquals(tableName, actualRequest.getTableName()); Assert.assertEquals(rowKey, actualRequest.getRowKey()); Assert.assertEquals(predicateFilter, actualRequest.getPredicateFilter()); Assert.assertEquals(trueMutations, actualRequest.getTrueMutationsList()); @@ -324,7 +316,7 @@ public void checkAndMutateRowExceptionTest() throws Exception { mockBigtable.addException(exception); try { - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); RowFilter predicateFilter = RowFilter.newBuilder().build(); List trueMutations = new ArrayList<>(); @@ -343,7 +335,7 @@ public void readModifyWriteRowTest() { ReadModifyWriteRowResponse expectedResponse = ReadModifyWriteRowResponse.newBuilder().build(); mockBigtable.addResponse(expectedResponse); - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List rules = new ArrayList<>(); @@ -354,7 +346,7 @@ public void readModifyWriteRowTest() { Assert.assertEquals(1, actualRequests.size()); ReadModifyWriteRowRequest actualRequest = (ReadModifyWriteRowRequest) actualRequests.get(0); - Assert.assertEquals(tableName, TableName.parse(actualRequest.getTableName())); + Assert.assertEquals(tableName, actualRequest.getTableName()); Assert.assertEquals(rowKey, actualRequest.getRowKey()); Assert.assertEquals(rules, actualRequest.getRulesList()); Assert.assertTrue( @@ -370,7 +362,7 @@ public void readModifyWriteRowExceptionTest() throws Exception { mockBigtable.addException(exception); try { - TableName tableName = TableName.of("[PROJECT]", "[INSTANCE]", "[TABLE]"); + String tableName = NameUtil.formatTableName("[PROJECT]", "[INSTANCE]", "[TABLE]"); ByteString rowKey = ByteString.copyFromUtf8("122"); List rules = new ArrayList<>(); From 2f4e1568b2b7b56a3f354d44e3aaa9e90c792b7d Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 21:05:13 -0500 Subject: [PATCH 11/13] fix int tests --- .kokoro/continuous/bigtableadmin-it.cfg | 2 +- .kokoro/nightly/bigtableadmin-it.cfg | 2 +- .kokoro/presubmit/bigtableadmin-it.cfg | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.kokoro/continuous/bigtableadmin-it.cfg b/.kokoro/continuous/bigtableadmin-it.cfg index 6694f4ba9189..b5129e51121e 100644 --- a/.kokoro/continuous/bigtableadmin-it.cfg +++ b/.kokoro/continuous/bigtableadmin-it.cfg @@ -8,7 +8,7 @@ env_vars: { env_vars: { key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable -Dbigtable.table=integration-tests" } env_vars: { diff --git a/.kokoro/nightly/bigtableadmin-it.cfg b/.kokoro/nightly/bigtableadmin-it.cfg index 6694f4ba9189..b5129e51121e 100644 --- a/.kokoro/nightly/bigtableadmin-it.cfg +++ b/.kokoro/nightly/bigtableadmin-it.cfg @@ -8,7 +8,7 @@ env_vars: { env_vars: { key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable -Dbigtable.table=integration-tests" } env_vars: { diff --git a/.kokoro/presubmit/bigtableadmin-it.cfg b/.kokoro/presubmit/bigtableadmin-it.cfg index 6694f4ba9189..b5129e51121e 100644 --- a/.kokoro/presubmit/bigtableadmin-it.cfg +++ b/.kokoro/presubmit/bigtableadmin-it.cfg @@ -8,7 +8,7 @@ env_vars: { env_vars: { key: "INTEGRATION_TEST_ARGS" - value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable" + value: "google-cloud-clients/google-cloud-bigtable -Dbigtable.env=prod -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable -Dbigtable.table=integration-tests" } env_vars: { From 469c53558f5f3b73747436c65fc868e966d89fca Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 21:14:52 -0500 Subject: [PATCH 12/13] don't double format the code --- google-cloud-clients/google-cloud-bigtable/synth.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable/synth.py b/google-cloud-clients/google-cloud-bigtable/synth.py index c2a6145cf2ba..f2b6178ac702 100644 --- a/google-cloud-clients/google-cloud-bigtable/synth.py +++ b/google-cloud-clients/google-cloud-bigtable/synth.py @@ -31,7 +31,6 @@ s.copy(data_library / 'grpc-google-cloud-bigtable-v2/src', '../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') s.copy(data_library / 'proto-google-cloud-bigtable-v2/src', '../../google-api-grpc/proto-google-cloud-bigtable-v2/src') -java.format_code('./src') java.format_code('../../google-api-grpc/grpc-google-cloud-bigtable-v2/src') java.format_code('../../google-api-grpc/proto-google-cloud-bigtable-v2/src') @@ -47,6 +46,7 @@ s.copy(admin_library / 'grpc-google-cloud-bigtable-admin-v2/src', '../../google-api-grpc/grpc-google-cloud-bigtable-admin-v2/src') s.copy(admin_library / 'proto-google-cloud-bigtable-admin-v2/src', '../../google-api-grpc/proto-google-cloud-bigtable-admin-v2/src') -java.format_code('./src') java.format_code('../../google-api-grpc/grpc-google-cloud-bigtable-admin-v2/src') java.format_code('../../google-api-grpc/proto-google-cloud-bigtable-admin-v2/src') + +java.format_code('./src') From b048c84da6d63b1ed5bf1a7b920c835f32c853a3 Mon Sep 17 00:00:00 2001 From: Igor Bernstein Date: Tue, 8 Jan 2019 21:19:26 -0500 Subject: [PATCH 13/13] fix up docs --- README.md | 1 - TESTING.md | 21 ++------------------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/README.md b/README.md index d13554ee7d29..1ab2a6b37238 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,6 @@ This library supports the following Google Cloud Platform services with clients This library supports the following Google Cloud Platform services with clients at an [Alpha](#versioning) quality level: - [Cloud Bigtable](google-cloud-clients/google-cloud-bigtable) (Alpha) -- [Cloud Bigtable Admin](google-cloud-clients/google-cloud-bigtable-admin) (Alpha) - [Cloud Compute](google-cloud-clients/google-cloud-compute) (Alpha) - [Cloud Dataproc](google-cloud-clients/google-cloud-dataproc) (Alpha) - [Cloud DNS](google-cloud-clients/google-cloud-dns) (Alpha) diff --git a/TESTING.md b/TESTING.md index 1b37a4b0d4eb..268e0fb73cf6 100644 --- a/TESTING.md +++ b/TESTING.md @@ -56,8 +56,8 @@ To use the `prod` environment: 2. Download the [JSON service account credentials file][create-service-account] from the Google Developer's Console. 3. Set the environment variable `GOOGLE_APPLICATION_CREDENTIALS` to the path of the credentials file -4. Set the system property `bigtable.env=prod` and `bigtable.table` to the full table name you - created earlier. Example: +4. Set the system property `bigtable.env=prod`, `bigtable.project`, `bigtable.instance` and + `bigtable.table` to created earlier. Example: ```shell mvn verify -am -pl google-cloud-bigtable \ -Dbigtable.env=prod \ @@ -66,23 +66,6 @@ To use the `prod` environment: -Dbigtable.table=my-table ``` -### Testing code that uses Bigtable Admin - -Bigtable Admin integration tests are run against a real Bigtable instance. - -To run the tests: -1. Set up the target table using `google-cloud-bigtable/scripts/setup-test-table.sh` -2. Download the [JSON service account credentials file][create-service-account] from the Google - Developer's Console. -3. Set the environment variable `GOOGLE_APPLICATION_CREDENTIALS` to the path of the credentials file -4. Set the system property `bigtable.instance` to the full instance name you - created earlier. Example: - ```shell - mvn verify -am -pl google-cloud-bigtable-admin \ - -Dbigtable.project=my-project - -Dbigtable.instance=my-instance - ``` - ### Testing code that uses Compute Currently, there isn't an emulator for Google Compute, so an alternative is to create a test