8000 Fix code snippet (wrong method name) in README.md by polleyg · Pull Request #1517 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Fix code snippet (wrong method name) in README.md #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 1 commit into from
Jan 10, 2017
Merged

Fix code snippet (wrong method name) in README.md #1517

tswast merged 1 commit into from
Jan 10, 2017

Conversation

@polleyg
Copy link
@polleyg polleyg commented Jan 10, 2017

Original code snippet in "Querying data" section:

..while (!queryResponse.jobComplete()) {..

This results in a compile error:

"Cannot resolve method jobComplete()"

The correct method is jobCompleted()

Fix code snippet (wrong method name) in README.md
d884fc0 
Original code snippet in _"Querying data"_ section: 

`..while (!queryResponse.jobComplete()) {..`

This results in a compile error: 

_"Cannot resolve method jobComplete()"_

The correct method is `jobCompleted()`
@googlebot
Copy link
googlebot commented Jan 10, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 10, 2017
@polleyg
Copy link
Author
polleyg commented Jan 10, 2017

I signed it!

@googlebot
Copy link
googlebot commented Jan 10, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 10, 2017
@coveralls
Copy link
coveralls commented Jan 10, 2017

Coverage Status

Coverage remained the same at 83.546% when pulling d884fc0 on polleyg:patch-1 into 3da8747 on GoogleCloudPlatform:master.

@lesv
Copy link
Contributor
lesv commented Jan 10, 2017

@tswast PTAL

tswast
tswast approved these changes Jan 10, 2017
View reviewed changes
8000
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit a12b4e7 into googleapis:master Jan 10, 2017
@garrettjonesgoogle
Copy link
Member
garrettjonesgoogle commented Jan 10, 2017

Ack try not to merge things between version updates in the future...

@polleyg polleyg deleted the patch-1 branch January 12, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

+1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@polleyg @googlebot @coveralls @lesv @garrettjonesgoogle @tswast
0