-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
Current sample retry settings here [1] set initialRpcTimeout = totalRpcTimeout, which effectively turns off retries. This has been causing almost daily escalations from major customers. Please fix to say something more reasonable like
Duration totalTimeout = Duration.ofSeconds(600); // default: 10 seconds Duration initialRpcTimeout = Duration.ofSeconds(1); // def
Also the mention of the defaults in the comments here is likely distracting. That should be documented in the RetrySettings class documentation instead.
Metadata
Metadata
Assignees
Labels
api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.