8000 Adding Snippets has errors · Issue #2413 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]

Skip to content

Adding Snippets has errors #2413

@michaelbausor

Description

@michaelbausor

script: https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/utilities/add_snippets_to_file.py

  1. Method signature with @nullable does not work.
    Fix:
    At this line in add_snippets_to_file.py#L99, replace the existing:
    ',\s+'.join(['(final\s+)?{}\s+{}'.format(
    with this:
    ',\s+'.join(['(@nullable\s+)?(final\s+)?{}\s+{}'.format(

  2. for all single line comments, the script either fails (when its the last method in the file) or appends javadocs to the successive method.

example:
/** some javadoc */
public String method ( String args );

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0