E3F3 Revisit the reserved terms in gapic/utils/reserved_names.py · Issue #2015 · googleapis/gapic-generator-python · GitHub
[go: up one dir, main page]
Skip to content

Revisit the reserved terms in gapic/utils/reserved_names.py #2015

New issue
New issue
Open
Open
Revisit the reserved terms in gapic/utils/reserved_names.py#2015
Labels
next major: breaking changethis is a change that we should wait to bundle into the next major versiontype: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
@Ark-kun

Description

@Ark-kun
Ark-kun
opened on Apr 24, 2024

I've just noticed that the generated classes mangle the license field name:

class Citation(proto.Message):
    r"""Source attributions for content."""
    ...
    license_: str = proto.Field(
        proto.STRING,
        number=5,
    )

https://github.com/googleapis/python-aiplatform/blob/c56dd50310ecc42d6a3b0cd2f30db71e8cad0cf6/google/cloud/aiplatform_v1/types/content.py#L572

I think this is incorrect. license is not a Python reserved keyword and it can definitely be used as an attribute name.

Metadata

Metadata

Assignees

No one assigned

    Labels

    next major: breaking changethis is a change that we should wait to bundle into the next major versiontype: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0