oboe: warn user of permission errors

philburk · philburk · commit 1f623872ba5c · 2020-06-17T11:23:02.000-07:00
AAudio returns confusing error codes when an open fails due to permission errors. Suggest a possible reason. Related to #888
diff --git a/src/aaudio/AudioStreamAAudio.cpp b/src/aaudio/AudioStreamAAudio.cpp
@@ -239,6 +239,11 @@ Result AudioStreamAAudio::open() {
         mAAudioStream.store(stream);
     }
     if (result != Result::OK) {
+        // Warn developer because ErrorInternal is not very informative.
+        if (result == Result::ErrorInternal && mDirection == Direction::Input) {
+            LOGW("AudioStreamAAudio.open() may have failed due to lack of "
+                 "audio recording permission.");
+        }
         goto error2;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,11 @@ Result AudioStreamAAudio::open() {`
`239`	`239`	`mAAudioStream.store(stream);`
`240`	`240`	`}`
`241`	`241`	`if (result != Result::OK) {`
	`242`	`+ // Warn developer because ErrorInternal is not very informative.`
	`243`	`+ if (result == Result::ErrorInternal && mDirection == Direction::Input) {`
	`244`	`+ LOGW("AudioStreamAAudio.open() may have failed due to lack of "`
	`245`	`+ "audio recording permission.");`
	`246`	`+ }`
`242`	`247`	`goto error2;`
`243`	`248`	`}`
`244`	`249`