Fix alphabetical key shortcuts. A SHIFT modifier key was registered by accident since the keyLabel from a LogicalKeyboardKey in Flutter changed to an upper case value (#866)

guibarrette · web-flow · commit a8ca32b01baf · 2021-07-23T09:10:36.000-07:00
Co-authored-by: Guillaume Barrette &lt;guillaume.barrette@gmail.com&gt;
diff --git a/plugins/menubar/lib/src/menu_channel.dart b/plugins/menubar/lib/src/menu_channel.dart
@@ -233,7 +233,7 @@ class MenuChannel {
         }
 
         if (key.keyLabel.isNotEmpty) {
-          channelRepresentation[_kShortcutKeyEquivalent] = key.keyLabel;
+          channelRepresentation[_kShortcutKeyEquivalent] = key.keyLabel.toLowerCase();
         } else {
           final specialKey = _shortcutSpecialKeyValues[key];
           if (specialKey == null) {

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ class MenuChannel {`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`if (key.keyLabel.isNotEmpty) {`
`236`		`- channelRepresentation[_kShortcutKeyEquivalent] = key.keyLabel;`
	`236`	`+ channelRepresentation[_kShortcutKeyEquivalent] = key.keyLabel.toLowerCase();`
`237`	`237`	`} else {`
`238`	`238`	`final specialKey = _shortcutSpecialKeyValues[key];`
`239`	`239`	`if (specialKey == null) {`