[file_selector] Ignore empty accept group lists on macOS (#837)

stuartmorgan-g · web-flow · commit a0ecd05a518f · 2021-02-25T09:42:59.000-08:00
The null safety migration for file_selector defaults the accept group to
an empty set rather than null, so empty set needs to be treated as no
filter. That's already the case for Windows and Linux; this makes macOS
consistent with that.
diff --git a/plugins/file_selector/file_selector_macos/macos/Classes/FLEFileSelectorPlugin.m b/plugins/file_selector/file_selector_macos/macos/Classes/FLEFileSelectorPlugin.m
@@ -56,7 +56,7 @@ - (void)configureSavePanel:(nonnull NSSavePanel *)panel
     panel.directoryURL = [NSURL URLWithString:initialDirectory];
   }
   NSArray<NSDictionary<NSString*, id>*>* acceptedTypeGroups = GetNonNullValueForKey(arguments, kAcceptedTypeGroupsKey);
-  if (acceptedTypeGroups) {
+  if (acceptedTypeGroups.count > 0) {
     // macOS doesn't support filter groups, so combine all allowed types into a flat list.
     NSMutableArray<NSString *> *allowedTypes = [NSMutableArray array];
     for (NSDictionary *filter in acceptedTypeGroups) {

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ - (void)configureSavePanel:(nonnull NSSavePanel *)panel`
`56`	`56`	`panel.directoryURL = [NSURL URLWithString:initialDirectory];`
`57`	`57`	`}`
`58`	`58`	`NSArray<NSDictionary<NSString, id>>* acceptedTypeGroups = GetNonNullValueForKey(arguments, kAcceptedTypeGroupsKey);`
`59`		`- if (acceptedTypeGroups) {`
	`59`	`+ if (acceptedTypeGroups.count > 0) {`
`60`	`60`	`// macOS doesn't support filter groups, so combine all allowed types into a flat list.`
`61`	`61`	`NSMutableArray<NSString > allowedTypes = [NSMutableArray array];`
`62`	`62`	`for (NSDictionary *filter in acceptedTypeGroups) {`