8000 Remove file_selector_windows (#894) · google/flutter-desktop-embedding@89c350f · GitHub
[go: up one dir, main page]
Skip to content

Commit 89c350f

Browse files
stuartmorgan-gstuartmorgan-g
authored
Remove file_selector_windows (#894)
Removes the Windows implementation, as it has now moved to flutter/plugins. Since the implementation is no longer part of this repository, removes it from the shared example app as well.
1 parent a550668 commit 89c350f

36 files changed

+30
-1687
lines changed

‎.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,13 @@ jobs:
6363
flutter build -v ${{matrix.TARGET}} --release
6464
working-directory: ${{ github.workspace }}/fde/testbed
6565
- name: Build file_selector implementations debug
66+
if: startsWith(matrix.os, 'macOS') || startsWith(matrix.os, 'ubuntu')
6667
run: |
6768
flutter packages get
6869
flutter build -v ${{matrix.TARGET}} --debug
6970
working-directory: ${{ github.workspace }}/fde/plugins/file_selector/example
7071
- name: Build file_selector implementations release
72+
if: startsWith(matrix.os, 'macOS') || startsWith(matrix.os, 'ubuntu')
7173
run: |
7274
flutter packages get
7375
flutter build -v ${{matrix.TARGET}} --release

‎plugins/file_selector/README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
# file_selector Desktop Implementations
22

3-
This folder contains unendorsed desktop implementations of the
3+
This folder contains unendorsed macOS and Linux implementations of the
44
[`file_selector`](https://github.com/flutter/plugins/tree/master/packages/file_selector)
55
plugin. They are not currently
66
[endorsed](https://flutter.dev/docs/development/packages-and-plugins/developing-packages#endorsed-federated-plugin),
77
and are here rather than in the flutter/plugins repository, because
88
there is not yet test infrastructure in place to test desktop plugins that
9-
show native UI, and so these implementations don't meet the Flutter testing
9+
show native UI, and they have not yet been refactored to support thorough
10+
unit testing, and so these implementations don't meet the Flutter testing
1011
requirements. Once automated tests are developed, they will be moved to
1112
flutter/plugins and endorsed.
1213

1314
Unlike other FDE plugins these are published normally, since they have a
1415
long-term support path. As with any unundorsed plugin, you need to
15-
depend directly on the implementation package ([`file_selector_linux`](https://pub.dev/packages/file_selector_linux), [`file_selector_macos`](https://pub.dev/packages/file_selector_macos), and/or [`file_selector_windows`](https://pub.dev/packages/file_selector_windows))
16+
depend directly on the implementation package
17+
([`file_selector_linux`](https://pub.dev/packages/file_selector_linux) and/or
18+
[`file_selector_macos`](https://pub.dev/packages/file_selector_macos))
1619
as well as the app-facing package (`file_selector`) in your `pubspec.yaml`.
1720

1821
See the implementation packages' READMEs for platform-specific notes.

‎plugins/file_selector/example/linux/flutter/generated_plugin_registrant.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// Generated file. Do not edit.
33
//
44

5+
// clang-format off
6+
57
#include "generated_plugin_registrant.h"
68

79
#include <file_selector_linux/file_selector_plugin.h>

‎plugins/file_selector/example/linux/flutter/generated_plugin_registrant.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// Generated file. Do not edit.
33
//
44

5+
// clang-format off
6+
57
#ifndef GENERATED_PLUGIN_REGISTRANT_
68
#define GENERATED_PLUGIN_REGISTRANT_
79

‎plugins/file_selector/example/pubspec.lock

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ packages:
77
name: async
88
url: "https://pub.dartlang.org"
99
source: hosted
10-
version: "2.5.0"
10+
version: "2.8.2"
1111
boolean_selector:
1212
dependency: transitive
1313
description:
@@ -21,14 +21,14 @@ packages:
2121
name: characters
2222
url: "https://pub.dartlang.org"
2323
source: hosted
24-
version: "1.1.0"
24+
version: "1.2.0"
2525
charcode:
2626
dependency: transitive
2727
description:
2828
name: charcode
2929
url: "https://pub.dartlang.org"
3030
source: hosted
31-
version: "1.2.0"
31+
version: "1.3.1"
3232
clock:
3333
dependency: transitive
3434
description:
@@ -63,28 +63,21 @@ packages:
6363
path: "../file_selector_linux"
6464
relative: true
6565
source: path
66-
version: "0.0.2"
66+
version: "0.0.2+1"
6767
file_selector_macos:
6868
dependency: "direct main"
6969
description:
7070
path: "../file_selector_macos"
7171
relative: true
7272
source: path
73-
version: "0.0.4"
73+
version: "0.0.4+1"
7474
file_selector_platform_interface:
7575
dependency: "direct main"
7676
description:
7777
name: file_selector_platform_interface
7878
url: "https://pub.dartlang.org"
7979
source: hosted
8080
version: "2.0.2"
81-
file_selector_windows:
82-
dependency: "direct main"
83-
description:
84-
path: "../file_selector_windows"
85-
relative: true
86-
source: path
87-
version: "0.0.2"
8881
flutter:
8982
dependency: "direct main"
9083
description: flutter
@@ -115,21 +108,28 @@ packages:
115108
name: matcher
116109
url: "https://pub.dartlang.org"
117110
source: hosted
118-
version: "0.12.10"
111+
version: "0.12.11"
112+
material_color_utilities:
113+
dependency: transitive
114+
description:
115+
name: material_color_utilities
116+
url: "https://pub.dartlang.org"
117+
source: hosted
118+
version: "0.1.3"
119119
meta:
120120
dependency: transitive
121121
description:
122122
name: meta
123123
url: "https://pub.dartlang.org"
124124
source: hosted
125-
version: "1.3.0"
125+
version: "1.7.0"
126126
path:
127127
dependency: transitive
128128
description:
129< 10000 code>129
name: path
130130
url: "https://pub.dartlang.org"
131131
source: hosted
132-
version: "1.8.0"
132+
version: "1.8.1"
133133
pedantic:
134134
dependency: transitive
135135
description:
@@ -190,7 +190,7 @@ packages:
190190
name: test_api
191191
url: "https://pub.dartlang.org"
192192
source: hosted
193-
version: "0.3.0"
193+
version: "0.4.9"
194194
typed_data:
195195
dependency: transitive
196196
description:
@@ -204,7 +204,7 @@ packages:
204204
name: vector_math
205205
url: "https://pub.dartlang.org"
206206
source: hosted
207-
version: "2.1.0"
207+
version: "2.1.1"
208208
sdks:
209-
dart: ">=2.12.0 <3.0.0"
209+
dart: ">=2.14.0 <3.0.0"
210210
flutter: ">=1.22.0"

‎plugins/file_selector/example/pubspec.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ dependencies:
1515
path: ../file_selector_linux
1616
file_selector_macos:
1717
path: ../file_selector_macos
18-
file_selector_windows:
19-
path: ../file_selector_windows
2018

2119
dev_dependencies:
2220
flutter_test:

‎plugins/file_selector/example/windows/.gitignore

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎plugins/file_selector/example/windows/CMakeLists.txt

Lines changed: 0 additions & 95 deletions
This file was deleted.

‎plugins/file_selector/example/windows/flutter/CMakeLists.txt

Lines changed: 0 additions & 102 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0