8000 Remove file_selector_macos (#897) · google/flutter-desktop-embedding@5c51870 · GitHub
[go: up one dir, main page]
Skip to content

Commit 5c51870

Browse files
stuartmorgan-gstuartmorgan-g
authored
Remove file_selector_macos (#897)
Removes the macOS implementation, as it has now moved to flutter/plugins. Since the implementation is no longer part of this repository, removes it from the shared example app as well.
1 parent a738913 commit 5c51870

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+24
-1710
lines changed

‎.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ jobs:
6363
flutter build -v ${{matrix.TARGET}} --release
6464
working-directory: ${{ github.workspace }}/fde/testbed
6565
- name: Build file_selector implementations debug
66-
if: startsWith(matrix.os, 'macOS') || startsWith(matrix.os, 'ubuntu')
66+
if: startsWith(matrix.os, 'ubuntu')
6767
run: |
6868
flutter packages get
6969
flutter build -v ${{matrix.TARGET}} --debug
7070
working-directory: ${{ github.workspace }}/fde/plugins/file_selector/example
7171
- name: Build file_selector implementations release
72-
if: startsWith(matrix.os, 'macOS') || startsWith(matrix.os, 'ubuntu')
72+
if: startsWith(matrix.os, 'ubuntu')
7373
run: |
7474
flutter packages get
7575
flutter build -v ${{matrix.TARGET}} --release

‎plugins/file_selector/README.md

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,18 @@
11
# file_selector Desktop Implementations
22

3-
This folder contains unendorsed macOS and Linux implementations of the
3+
This folder contains the unendorsed Linux implementation of the
44
[`file_selector`](https://github.com/flutter/plugins/tree/master/packages/file_selector)
5-
plugin. They are not currently
5+
plugin. It is not currently
66
[endorsed](https://flutter.dev/docs/development/packages-and-plugins/developing-packages#endorsed-federated-plugin),
7-
and are here rather than in the flutter/plugins repository, because
8-
there is not yet test infrastructure in place to test desktop plugins that
9-
show native UI, and they have not yet been refactored to support thorough
10-
unit testing, and so these implementations don't meet the Flutter testing
11-
requirements. Once automated tests are developed, they will be moved to
12-
flutter/plugins and endorsed.
7+
and is here rather than in the flutter/plugins repository, because
8+
it has not yet been refactored to support thorough
9+
unit testing, and so it doesn't meet the Flutter testing
10+
requirements. Once automated tests are developed, it will be moved to
11+
flutter/plugins and endorsed (as has already happened with Windows and
12+
macOS).
1313

14-
Unlike other FDE plugins these are published normally, since they have a
14+
Unlike other FDE plugins it is published normally, since it has a
1515
long-term support path. As with any unundorsed plugin, you need to
1616
depend directly on the implementation package
17-
([`file_selector_linux`](https://pub.dev/packages/file_selector_linux) and/or
18-
[`file_selector_macos`](https://pub.dev/packages/file_selector_macos))
17+
([`file_selector_linux`](https://pub.dev/packages/file_selector_linux))
1918
as well as the app-facing package (`file_selector`) in your `pubspec.yaml`.
20-
21-
See the implementation packages' READMEs for platform-specific notes.

‎plugins/file_selector/example/linux/flutter/generated_plugins.cmake

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ list(APPEND FLUTTER_PLUGIN_LIST
66
file_selector_linux
77
)
88

9+
list(APPEND FLUTTER_FFI_PLUGIN_LIST
10+
)
11+
912
set(PLUGIN_BUNDLED_LIBRARIES)
1013

1114
foreach(plugin ${FLUTTER_PLUGIN_LIST})
@@ -14,3 +17,8 @@ foreach(plugin ${FLUTTER_PLUGIN_LIST})
1417
list(APPEND PLUGIN_BUNDLED_LIBRARIES $<TARGET_FILE:${plugin}_plugin>)
1518 EF25
list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${plugin}_bundled_libraries})
1619
endforeach(plugin)
20+
21+
foreach(ffi_plugin ${FLUTTER_FFI_PLUGIN_LIST})
22+
add_subdirectory(flutter/ephemeral/.plugin_symlinks/${ffi_plugin}/linux plugins/${ffi_plugin})
23+
list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${ffi_plugin}_bundled_libraries})
24+
endforeach(ffi_plugin)

‎plugins/file_selector/example/macos/.gitignore

Lines changed: 0 additions & 6 deletions
This file was deleted.

‎plugins/file_selector/example/macos/Flutter/Flutter-Debug.xcconfig

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎plugins/file_selector/example/macos/Flutter/Flutter-Release.xcconfig

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎plugins/file_selector/example/macos/Flutter/GeneratedPluginRegistrant.swift

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎plugins/file_selector/example/macos/Podfile

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎plugins/file_selector/example/macos/Podfile.lock

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0