Update JSON data in refresh()

bluekeyes · bluekeyes · commit 6290a69d0cef · 2016-05-16T18:52:04.000-07:00
Otherwise, only attributes handled in _update_attributes() are refreshed
and new values from the response are not available.
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -127,4 +127,6 @@ Contributors
 
 - Matthew Krueger (@mlkrueger1987)
 
-- Dejan Svetec (@dsvetec)
+- Dejan Svetec (@dsvetec)
+
+- Billy Keyes (@bluekeyes)
diff --git a/github3/models.py b/github3/models.py
@@ -285,6 +285,7 @@ def refresh(self, conditional=False):
         headers = headers or None
         json = self._json(self._get(self._api, headers=headers), 200)
         if json is not None:
+            self._json_data = json
             self._update_attributes(json)
         return self
 
diff --git a/tests/unit/test_models.py b/tests/unit/test_models.py
@@ -1,4 +1,5 @@
 import io
+import json
 import pytest
 import requests
 
@@ -184,6 +185,21 @@ def test_refresh_etag(self):
             headers=expected_headers,
         )
 
+    def test_refresh_json(self):
+        """Verify refreshing an object updates stored json data."""
+        expected_data = {
+            'changed_files': 4
+        }
+        response = requests.Response()
+        response.status_code = 200
+        response.raw = io.BytesIO(json.dumps(expected_data).encode('utf8'))
+        self.session.get.return_value = response
+
+        self.instance.refresh()
+
+        assert 'changed_files' in self.instance.as_dict()
+        assert self.instance.changed_files == 4
+
     def test_strptime(self):
         """Verify that method converts ISO 8601 formatted string."""
         dt = self.instance._strptime('2015-06-18T19:53:04Z')
