go/analysis/passes/deepequalerrors: audit for types.Alias safety

adonovan · gopherbot · commit 314368ddf001 · 2024-02-08T21:53:06.000Z
Updates golang/go#65294 Change-Id: I00543b00c830ff5a4fe442f1bcf6f21ab0b12d97 Reviewed-on: https://go-review.googlesource.com/c/tools/+/559916 Reviewed-by: Tim King <taking@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/go/analysis/passes/deepequalerrors/deepequalerrors.go b/go/analysis/passes/deepequalerrors/deepequalerrors.go
@@ -15,6 +15,7 @@ import (
 	"golang.org/x/tools/go/analysis/passes/internal/analysisutil"
 	"golang.org/x/tools/go/ast/inspector"
 	"golang.org/x/tools/go/types/typeutil"
+	"golang.org/x/tools/internal/aliases"
 )
 
 const Doc = `check for calls of reflect.DeepEqual on error values
@@ -101,7 +102,8 @@ func containsError(typ types.Type) bool {
 					return true
 				}
 			}
-		case *types.Named:
+		case *types.Named,
+			*aliases.Alias:
 			return check(t.Underlying())
 
 		// We list the remaining valid type kinds for completeness.

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ import (`
`15`	`15`	`"golang.org/x/tools/go/analysis/passes/internal/analysisutil"`
`16`	`16`	`"golang.org/x/tools/go/ast/inspector"`
`17`	`17`	`"golang.org/x/tools/go/types/typeutil"`
	`18`	`+ "golang.org/x/tools/internal/aliases"`
`18`	`19`	`)`
`19`	`20`
`20`	`21`	const Doc = `check for calls of reflect.DeepEqual on error values
`@@ -101,7 +102,8 @@ func containsError(typ types.Type) bool {`
`101`	`102`	`return true`
`102`	`103`	`}`
`103`	`104`	`}`
`104`		`- case *types.Named:`
	`105`	`+ case *types.Named,`
	`106`	`+ *aliases.Alias:`
`105`	`107`	`return check(t.Underlying())`
`106`	`108`
`107`	`109`	`// We list the remaining valid type kinds for completeness.`