8000 net/http: add missing ServeTLS on the comment of http.Server.Shutdown · golang/go@e513cd4 · GitHub
[go: up one dir, main page]

Skip to content

Commit e513cd4

Browse files
t-katsumuragopherbot
authored andcommitted
net/http: add missing ServeTLS on the comment of http.Server.Shutdown
A sentinel error http.ErrServerClosed is returned after Server.Shutdown and Server.Close but it is not documented on the Server.Shutdown while other methods such as Server.Serve are documented on it. Change-Id: Id82886d9d6a1474a514d62e9169b35f3579a9eee Reviewed-on: https://go-review.googlesource.com/c/go/+/671695 Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Sean Liao <sean@liao.dev>
1 parent e666f1d commit e513cd4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/net/http/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3154,7 +3154,7 @@ const shutdownPollIntervalMax = 500 * time.Millisecond
31543154
// Shutdown returns the context's error, otherwise it returns any
31553155
// error returned from closing the [Server]'s underlying Listener(s).
31563156
//
3157-
// When Shutdown is called, [Serve], [ListenAndServe], and
3157+
// When Shutdown is called, [Serve], [ServeTLS], [ListenAndServe], and
31583158
// [ListenAndServeTLS] immediately return [ErrServerClosed]. Make sure the
31593159
// program doesn't exit and waits instead for Shutdown to return.
31603160
//

0 commit comments

Comments
 (0)
0