Update comments now have decided how exceptions get propagated

ncw · ncw · commit ca73609bad87 · 2013-11-29T11:07:50.000Z
diff --git a/builtin/builtin.go b/builtin/builtin.go
@@ -288,7 +288,7 @@ func builtin___build_class__(self py.Object, args py.Tuple, kwargs py.StringDict
 	// fmt.Printf("locals = %#v\n", locals)
 	// fmt.Printf("ns = %#v\n", ns)
 	if err != nil {
-		// FIXME
+		// propagate the error
 		panic(err)
 	}
 	if cell != nil {
diff --git a/py/function.go b/py/function.go
@@ -125,7 +125,7 @@ func (f *Function) M__call__(args Tuple, kwargs StringDict) Object {
 	}
 	result, err := Run(f.Globals, locals, f.Code)
 	if err != nil {
-		// FIXME - do what exactly!
+		// Propagate the error
 		panic(err)
 	}
 	return result
diff --git a/py/generator.go b/py/generator.go
@@ -57,8 +57,8 @@ func (it *Generator) M__next__() Object {
 	// Push a None on the stack for next time
 	// FIXME this value is the one sent by Send
 	it.Frame.Stack = append(it.Frame.Stack, None)
-	// FIXME not correct
 	if err != nil {
+		// Propagate the error
 		panic(err)
 	}
 	if it.Frame.Yielded {

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ func builtin___build_class__(self py.Object, args py.Tuple, kwargs py.StringDict`
`288`	`288`	`// fmt.Printf("locals = %#v\n", locals)`
`289`	`289`	`// fmt.Printf("ns = %#v\n", ns)`
`290`	`290`	`if err != nil {`
`291`		`- // FIXME`
	`291`	`+ // propagate the error`
`292`	`292`	`panic(err)`
`293`	`293`	`}`
`294`	`294`	`if cell != nil {`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ func (f *Function) M__call__(args Tuple, kwargs StringDict) Object {`
`125`	`125`	`}`
`126`	`126`	`result, err := Run(f.Globals, locals, f.Code)`
`127`	`1 BA5C 27`	`if err != nil {`
`128`		`- // FIXME - do what exactly!`
	`128`	`+ // Propagate the error`
`129`	`129`	`panic(err)`
`130`	`130`	`}`
`131`	`131`	`return result`