Return default avatar url when user id is zero rather than updating database (#34094)

lunny · web-flow · commit 88352e0b252e · 2025-04-02T01:03:27.000Z
diff --git a/models/user/avatar.go b/models/user/avatar.go
@@ -61,7 +61,9 @@ func GenerateRandomAvatar(ctx context.Context, u *User) error {
 
 // AvatarLinkWithSize returns a link to the user's avatar with size. size <= 0 means default size
 func (u *User) AvatarLinkWithSize(ctx context.Context, size int) string {
-	if u.IsGhost() || u.IsGiteaActions() {
+	// ghost user was deleted, Gitea actions is a bot user, 0 means the user should be a virtual user
+	// which comes from git configure information
+	if u.IsGhost() || u.IsGiteaActions() || u.ID <= 0 {
 		return avatars.DefaultAvatarLink()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,9 @@ func GenerateRandomAvatar(ctx context.Context, u *User) error {`
`61`	`61`
`62`	`62`	`// AvatarLinkWithSize returns a link to the user's avatar with size. size <= 0 means default size`
`63`	`63`	`func (u *User) AvatarLinkWithSize(ctx context.Context, size int) string {`
`64`		`- if u.IsGhost() \|\| u.IsGiteaActions() {`
	`64`	`+ // ghost user was deleted, Gitea actions is a bot user, 0 means the user should be a virtual user`
	`65`	`+ // which comes from git configure information`
	`66`	`+ if u.IsGhost() \|\| u.IsGiteaActions() \|\| u.ID <= 0 {`
`65`	`67`	`return avatars.DefaultAvatarLink()`
`66`	`68`	`}`
`67`	`69`