8000 Unlogged error in ssh/common.go · Issue #185 · go-git/go-git · GitHub
[go: up one dir, main page]

Skip to content
Unlogged error in ssh/common.go #185
Closed
@cep21

Description

@cep21

The file ssh/common.go contains the following code

func (r *runner) Command(cmd string, ep *transport.Endpoint, auth transport.AuthMethod) (common.Command, error) {
	c := &command{command: cmd, endpoint: ep, config: r.config}
	if auth != nil {
		c.setAuth(auth)
	}

	if err := c.connect(); err != nil {
		return nil, err
	}
	return c, nil
}

The setAuth function returns an error, but any error returned is not logged or returned to the client. This can make it difficult to customize the auth function of the library since users will be unaware their custom auth is not used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0