8000 Merge pull request #1586 from onee-only/fix-and-improve-transport-tests · go-git/go-git@d1ff2e1 · GitHub
[go: up one dir, main page]

Skip to content

Commit d1ff2e1

Browse files
authored
Merge pull request #1586 from onee-only/fix-and-improve-transport-tests
Improve transport tests
2 parents 24d6c16 + 9fbc38a commit d1ff2e1

File tree

15 files changed

+347
-520
lines changed

15 files changed

+347
-520
lines changed

internal/transport/http/proxy_test.go

Lines changed: 0 additions & 61 deletions
This file was deleted.

internal/transport/http/test/test_utils.go

Lines changed: 0 additions & 130 deletions
This file was deleted.

internal/transport/ssh/test/proxy_test.go

Lines changed: 0 additions & 99 deletions
This file was deleted.

internal/transport/ssh/test/test_utils.go

Lines changed: 0 additions & 83 deletions
This file was deleted.

internal/transport/test/common.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,20 @@ func FreePort() (int, error) {
3636

3737
return l.Addr().(*net.TCPAddr).Port, l.Close()
3838
}
39+
40+
// ListenTCP listens localhost:0.
41+
// It reserves the listener to be closed on t.CleanUp.
42+
func ListenTCP(t testing.TB) *net.TCPListener {
43+
t.Helper()
44+
l, err := net.Listen("tcp", "localhost:0")
45+
require.NoError(t, err)
46+
47+
t.Cleanup(func() {
48+
err := l.Close()
49+
if err != nil {
50+
require.ErrorIs(t, err, net.ErrClosed)
51+
}
52+
})
53+
54+
return l.(*net.TCPListener)
55+
}

0 commit comments

Comments
 (0)
0