8000 fixed tests · gmiretti/server-client-python@dcf8c87 · GitHub
[go: up one dir, main page]
Skip to content

Commit dcf8c87

Browse files
author
bzhang
committed
fixed tests
1 parent eaf86e4 commit dcf8c87

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

‎samples/materialize_workbooks.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ def update_project_by_path(args, materialized_views_mode, password, site_content
135135
if not assert_site_enabled_for_materialized_views(server, site_content_url):
136136
return False
137137
projects = [project for project in TSC.Pager(server.projects) if project.name == project_name]
138-
if not assert_project_valid(args, args.project_path, projects):
138+
if not assert_project_valid(args.project_path, projects):
139139
return False
140-
140+
141141
possible_paths = get_project_paths(server, projects)
142142
update_project(possible_paths[args.project_path], server, materialized_views_mode)
143143
return True
@@ -154,7 +154,7 @@ def update_project_by_name(args, materialized_views_config, password, site_conte
154154
return False
155155
# get all projects with given name
156156
projects = [project for project in TSC.Pager(server.projects) if project.name == args.project_name]
157-
if not assert_project_valid(args, args.project_name, projects):
157+
if not assert_project_valid(args.project_name, projects):
158158
return False
159159

160160
if len(projects) > 1:
@@ -290,7 +290,7 @@ def assert_site_enabled_for_materialized_views(server, site_content_url):
290290
return True
291291

292292

293-
def assert_project_valid(args, project_name, projects):
293+
def assert_project_valid(project_name, projects):
294294
if len(projects) == 0:
295295
print("Cannot find project: {}".format(project_name))
296296
return False

‎test/assets/workbook_update.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
<?xml version='1.0' encoding='UTF-8'?>
22
<tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
3-
<workbook id="1f951daf-4061-451a-9df1-69a8062664f2" name="renamedWorkbook" contentUrl="RESTAPISample" showTabs="true" size="1" createdAt="2016-08-18T18:25:36Z" updatedAt="2016-08-18T18:29:36Z" materializedViewsEnabled="true">
3+
<workbook id="1f951daf-4061-451a-9df1-69a8062664f2" name="renamedWorkbook" contentUrl="RESTAPISample" showTabs="true" size="1" createdAt="2016-08-18T18:25:36Z" updatedAt="2016-08-18T18:29:36Z">
44
<project id="1d0304cd-3796-429f-b815-7258370b9b74" name="Tableau" />
55
<owner id="dd2239f6-ddf1-4107-981a-4cf94e415794" />
66
<tags />
7+
<materializedViewsConfig materializedViewsEnabled="true" runMaterializationNow="false" />
78
</workbook>
89
</tsResponse>

‎test/test_workbook.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,17 @@ def test_update(self):
119119
single_workbook._id = '1f951daf-4061-451a-9df1-69a8062664f2'
120120
single_workbook.owner_id = 'dd2239f6-ddf1-4107-981a-4cf94e415794'
121121
single_workbook.name = 'renamedWorkbook'
122-
single_workbook.materialized_views_enabled = True
122+
single_workbook.materialized_views_config = {'materialized_views_enabled': True,
123+
'run_materialization_now': False}
123124
single_workbook = self.server.workbooks.update(single_workbook)
124125

125126
self.assertEqual('1f951daf-4061-451a-9df1-69a8062664f2', single_workbook.id)
126127
self.assertEqual(True, single_workbook.show_tabs)
127128
self.assertEqual('1d0304cd-3796-429f-b815-7258370b9b74', single_workbook.project_id)
128129
self.assertEqual('dd2239f6-ddf1-4107-981a-4cf94e415794', single_workbook.owner_id)
129130
self.assertEqual('renamedWorkbook', single_workbook.name)
130-
self.assertEqual(True, single_workbook.materialized_views_mode)
131+
self.assertEqual(True, single_workbook.materialized_views_config['materialized_views_enabled'])
132+
self.assertEqual(False, single_workbook.materialized_views_config['run_materialization_now'])
131133

132134
def test_update_missing_id(self):
133135
single_workbook = TSC.WorkbookItem('test')

0 commit comments

Comments
 (0)
0