8000 Fix tests that are broken under Python 2.7. by marcusrbrown · Pull Request #86 · gitpython-developers/GitPython · GitHub
[go: up one dir, main page]
Skip to content

Fix tests that are broken under Python 2.7. #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix tests that are broken under Python 2.7. #86

wants to merge 2 commits into from

Conversation

marcusrbrown
Copy link
Contributor

In Python 2.7, the unittest module was revamped to match the Python 3 version. Python 2.7 unittest doesn't run class fixtures if the class method isn't named setUpClass(). This fixes the tests that throw AttributeError under Python 2.7 (also mentioned in Issues #20 and #62):

"AttributeError: 'TestGit' object has no attribute 'rorepo'"

I also tested under Python 2.6 to ensure that those tests would still run. I have a similar patch incoming on master.

@marcusrbrown marcusrbrown mentioned this pull request Jan 11, 2013
Closed
@Byron
Copy link
Member
Byron commented Nov 19, 2014

Thank you.
This fix is already integrated by now.

@Byron Byron closed this Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusrbrown @Byron
0