8000 Timeout error message should be a bytes string · Issue #625 · gitpython-developers/GitPython · GitHub
[go: up one dir, main page]

Skip to content
Timeout error message should be a bytes string #625
Closed
@JoshData

Description

@JoshData

At https://github.com/gitpython-developers/GitPython/blob/master/git/cmd.py#L650, I think the error message about timeouts should be a b"..." bytes string and not a regular string. You can see right afterwards in the endswith call that the string is expected to be a bytes string.

                        stderr_value = 'Timeout: the command "%s" did not complete in %d ' \
                                       'secs.' % (" ".join(command), kill_after_timeout)
                ....
                if stderr_value.endswith(b"\n"):
                    stderr_value = stderr_value[:-1]

So it should be:

                        stderr_value = b'Timeout: the command "%s" did not complete in %d ' \
                                       b'secs.' % (" ".join(command), kill_after_timeout)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0