8000 incorrect 'git' version for GitPython==3.1.28 installed from PyPI · Issue #1500 · gitpython-developers/GitPython · GitHub
[go: up one dir, main page]
Skip to content

incorrect 'git' version for GitPython==3.1.28 installed from PyPI #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
boegel opened this issue Oct 10, 2022 · 3 comments
Closed

incorrect 'git' version for GitPython==3.1.28 installed from PyPI #1500

boegel opened this issue Oct 10, 2022 · 3 comments
Labels
acknowledged
Milestone
v3.1.29 - Bugfixes

Comments

@boegel
Copy link
Contributor
boegel commented Oct 10, 2022

It looks like there's mistake in the release of GitPython 3.1.28 with respect to the version.

Here's the output I'm getting when GitPython 3.1.28 is installed (using pip3 install)

$ python3 -c 'import git; print(git.__version__)'
git

With older GitPython versions, I'm getting a proper version instead:

$ python3 -c 'import git; print(git.__version__)'
3.1.27
This was referenced Oct 10, 2022
Merged
Merged
@branfosj
Copy link
branfosj commented Oct 10, 2022 •
edited
Loading

In 21ec529 there is the change:

-__version__ = 'git'
+__version__ = "git"
 
 
-#{ Initialization
+# { Initialization
 def _init_externals() -> None:
     """Initialize external projects by putting them into the path"""
-    if __version__ == 'git' and 'PYOXIDIZER' not in os.environ:
-        sys.path.insert(1, osp.join(osp.dirname(__file__), 'ext', 'gitdb'))
+    if __version__ == "git" and "PYOXIDIZER" not in os.environ:
+        sys.path.insert(1, osp.join(osp.dirname(__file__), "ext", "gitdb"))

However, setup.py puts the version in by doing a find/replace with a search for 'git':

line = line.replace("'git'", "'%s'" % VERSION)

and that fails, which leaves "git" in two places in __init__.py.

Sorry, something went wrong.

Byron added a commit that referenced this issue Oct 10, 2022
@Byron
fix version replacement in setup.py (#1500)
be3400b 
It would fail to perform the replacement, but unfortunately wouldn't
stop the release process.

The latter could be done, but isn't implemented either as it's hard
to test given everything is runtime.
@Byron Byron added this to the v3.1.29 - Bugfixes milestone Oct 10, 2022
@Byron
Copy link
Member
Byron commented Oct 10, 2022

Thanks for letting me know! This should be fixed with v3.1.29, please let me know in the comments if it isn't though.

@Byron Byron closed this as completed Oct 10, 2022
@boegel
Copy link
Contributor Author
boegel commented Oct 11, 2022

I can confirm that a proper versio is printed for GitPython 3.1.29, thanks a lot for the quick fix!

$ pip3 install GitPython==3.1.29
$ python3 -c 'import git; print(git.__version__)'
3.1.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Milestone
v3.1.29 - Bugfixes
Development

No branches or pull requests
3 participants
@branfosj @Byron @boegel
0