Converting path in clone and clone_from to str before any other operation in case eg pathlib.Path is passed

mikicz · mikicz · commit 4ee7e1a72aa2 · 2017-10-07T12:23:46.000+02:00
diff --git a/AUTHORS b/AUTHORS
@@ -23,5 +23,6 @@ Contributors are:
 -Ken Odegard <ken.odegard _at_ gmail.com>
 -Alexis Horgix Chotard
 -Piotr Babij <piotr.babij _at_ gmail.com>
+-Mikuláš Poul <mikulaspoul _at_ gmail.com>
 
 Portions derived from other open source works and are clearly marked.
diff --git a/git/repo/base.py b/git/repo/base.py
@@ -905,6 +905,10 @@ def _clone(cls, git, url, path, odb_default_type, progress, **kwargs):
 
         odbt = kwargs.pop('odbt', odb_default_type)
 
+        # when pathlib.Path or other classbased path is passed
+        if not isinstance(path, str):
+            path = str(path)
+
         ## A bug win cygwin's Git, when `--bare` or `--separate-git-dir`
         #  it prepends the cwd or(?) the `url` into the `path, so::
         #        git clone --bare  /cygwin/d/foo.git  C:\\Work
diff --git a/git/test/test_repo.py b/git/test/test_repo.py
@@ -16,6 +16,11 @@
 except ImportError:
     from unittest2 import skipIf, SkipTest
 
+try:
+    import pathlib
+except ImportError:
+    pathlib = None
+
 from git import (
     InvalidGitRepositoryError,
     Repo,
@@ -210,6 +215,15 @@ def test_clone_from_keeps_env(self, rw_dir):
 
         assert_equal(environment, cloned.git.environment())
 
+    @with_rw_directory
+    def test_clone_from_pathlib(self, rw_dir):
+        if pathlib is None:  # pythons bellow 3.4 don't have pathlib
+            raise SkipTest("pathlib was introduced in 3.4")
+
+        original_repo = Repo.init(osp.join(rw_dir, "repo"))
+
+        Repo.clone_from(original_repo.git_dir, pathlib.Path(rw_dir) / "clone_pathlib")
+
     def test_init(self):
         prev_cwd = os.getcwd()
         os.chdir(tempfile.gettempdir())
