Fix the dynamic payload validation (#445)

Noah Lee · web-flow · commit 18f83181c15b · 2022-06-12T21:18:12.000+09:00
diff --git a/internal/interactor/validator.go b/internal/interactor/validator.go
@@ -176,6 +176,10 @@ type DynamicPayloadValidator struct {
 }
 
 func (v *DynamicPayloadValidator) Validate(d *ent.Deployment) error {
+	if d.IsRollback {
+		return nil
+	}
+
 	if !v.Env.IsDynamicPayloadEnabled() {
 		return nil
 	}
diff --git a/internal/interactor/validator_test.go b/internal/interactor/validator_test.go
@@ -138,3 +138,13 @@ func TestSerializationValidator_Validate(t *testing.T) {
 		}
 	})
 }
+
+func TestDynamicPayloadValidator_Validate(t *testing.T) {
+	t.Run("Returns nil if it is rollback.", func(t *testing.T) {
+		v := &i.DynamicPayloadValidator{Env: &extent.Env{}}
+
+		if err := v.Validate(&ent.Deployment{IsRollback: true}); err != nil {
+			t.Fatalf("Validate returns an error: %s", err)
+		}
+	})
+}

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,10 @@ type DynamicPayloadValidator struct {`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`func (v DynamicPayloadValidator) Validate(d ent.Deployment) error {`
	`179`	`+ if d.IsRollback {`
	`180`	`+ return nil`
	`181`	`+ }`
	`182`	`+`
`179`	`183`	`if !v.Env.IsDynamicPayloadEnabled() {`
`180`	`184`	`return nil`
`181`	`185`	`}`
Original file line number	Diff line number	Diff line change
`@@ -138,3 +138,13 @@ func TestSerializationValidator_Validate(t *testing.T) {`
`138`	`138`	`}`
`139`	`139`	`})`
`140`	`140`	`}`
	`141`	`+`
	`142`	`+func TestDynamicPayloadValidator_Validate(t *testing.T) {`
	`143`	`+ t.Run("Returns nil if it is rollback.", func(t *testing.T) {`
	`144`	`+ v := &i.DynamicPayloadValidator{Env: &extent.Env{}}`
	`145`	`+`
	`146`	`+ if err := v.Validate(&ent.Deployment{IsRollback: true}); err != nil {`
	`147`	`+ t.Fatalf("Validate returns an error: %s", err)`
	`148`	`+ }`
	`149`	`+ })`
	`150`	`+}`