8000 defaultStickyColumnName prop not working · Issue #19 · githubocto/flat-ui · GitHub
[go: up one dir, main page]
Skip to content
defaultStickyColumnName prop not working #19
New issue
New issue
Closed
Closed
defaultStickyColumnName prop not working#19
@paulshen

Description

@paulshen
paulshen
opened on Jan 21, 2022

Thanks for this awesome library! I noticed that defaultStickyColumnName was not being respected when testing it out.

Here's a codesandbox repro https://codesandbox.io/s/dazzling-cray-bjmjs

It seems like columnNames is updated after handleStickyColumnNameChange

flat-ui/src/components/grid.tsx

Lines 168 to 171 in 07b88ec

React.useEffect(() => {
if (props.defaultStickyColumnName)
handleStickyColumnNameChange(props.defaultStickyColumnName);
}, [props.defaultStickyColumnName, props.data]);

flat-ui/src/components/grid.tsx

Line 183 in 07b88ec

React.useEffect(updateColumnNames, [props.data, stickyColumnName]);

which causes the issue in this logic

flat-ui/src/store.ts

Lines 86 to 90 in 07b88ec

handleStickyColumnNameChange: (columnName) =>
set((draft) => {
if (!draft.columnNames.includes(columnName)) return;
draft.stickyColumnName = columnName;
}),

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0