feat: show blank cells as blank

Amelia Wattenberger · Amelia Wattenberger · commit 75ac3ce65975 · 2022-01-20T15:00:23.000-05:00
instead of "-"
diff --git a/src/components/cells/date.tsx b/src/components/cells/date.tsx
@@ -14,7 +14,7 @@ export function DateCell(props: DateCellProps) {
       tw="overflow-ellipsis block whitespace-nowrap overflow-hidden"
       title={props.rawValue}
     >
-      {props.value ? formatDate(props.value) : '-'}
+      {props.value ? formatDate(props.value) : ''}
     </span>
   );
 }
diff --git a/src/components/cells/number.tsx b/src/components/cells/number.tsx
@@ -8,7 +8,7 @@ interface NumberCellProps {
 export function NumberCell(props: NumberCellProps) {
   return (
     <span tw="text-right font-mono text-sm block w-full" title={props.rawValue}>
-      {Number.isFinite(props.value) ? props.value.toLocaleString() : '—'}
+      {Number.isFinite(props.value) ? props.value.toLocaleString() : !props.value ? "" : '—'}
     </span>
   );
 }
diff --git a/src/components/cells/time.tsx b/src/components/cells/time.tsx
@@ -15,7 +15,7 @@ export function TimeCell(props: TimeCellProps) {
       tw="overflow-ellipsis block whitespace-nowrap overflow-hidden"
       title={props.rawValue}
     >
-      {props.value ? formatTime(props.value) : '-'}
+      {props.value ? formatTime(props.value) : ''}
     </span>
   );
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ export function DateCell(props: DateCellProps) {`
`14`	`14`	`tw="overflow-ellipsis block whitespace-nowrap overflow-hidden"`
`15`	`15`	`title={props.rawValue}`
`16`	`16`	`>`
`17`		`- {props.value ? formatDate(props.value) : '-'}`
	`17`	`+ {props.value ? formatDate(props.value) : ''}`
`18`	`18`	`</span>`
`19`	`19`	`);`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ interface NumberCellProps {`
`8`	`8`	`export function NumberCell(props: NumberCellProps) {`
`9`	`9`	`return (`
`10`	`10`	`<span tw="text-right font-mono text-sm block w-full" title={props.rawValue}>`
`11`		`- {Number.isFinite(props.value) ? props.value.toLocaleString() : '—'}`
	`11`	`+ {Number.isFinite(props.value) ? props.value.toLocaleString() : !props.value ? "" : '—'}`
`12`	`12`	`</span>`
`13`	`13`	`);`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ export function TimeCell(props: TimeCellProps) {`
`15`	`15`	`tw="overflow-ellipsis block whitespace-nowrap overflow-hidden"`
`16`	`16`	`title={props.rawValue}`
`17`	`17`	`>`
`18`		`- {props.value ? formatTime(props.value) : '-'}`
	`18`	`+ {props.value ? formatTime(props.value) : ''}`
`19`	`19`	`</span>`
`20`	`20`	`);`
`21`	`21`	`}`