Update notebook comment view in response to mutations (microsoft#219927)

rehmsen · web-flow · commit 5b8edf2b36bb · 2024-07-15T17:35:55.000+02:00
Update notebook comment view in response to mutations. Fixes Rendered notebook cell comments are not updated when the underlying data changes via the extension APIs microsoft#214248 This short circuiting makes it so that the comment is not updated. Not having this return early is consistent with the corresponding function in commentThreadZoneWidget.ts.
diff --git a/src/vs/workbench/contrib/notebook/browser/view/cellParts/cellComments.ts b/src/vs/workbench/contrib/notebook/browser/view/cellParts/cellComments.ts
@@ -110,10 +110,6 @@ export class CellComments extends CellContentPart {
 				this.currentElement.commentHeight = 0;
 				return;
 			}
-			if (this._commentThreadWidget.value.commentThread === info.thread) {
-				this.currentElement.commentHeight = this._calculateCommentThreadHeight(this._commentThreadWidget.value.getDimensions().height);
-				return;
-			}
 
 			await this._commentThreadWidget.value.updateCommentThread(info.thread);
 			this.currentElement.commentHeight = this._calculateCommentThreadHeight(this._commentThreadWidget.value.getDimensions().height);
