Merge pull request numpy#6057 from bertrand-l/linspace_nonnegative_num

jaimefrio · jaimefrio · commit 0c97cdeb1b29 · 2015-07-09T00:01:59.000-07:00
EHN: raise error for negative 'num' in linspace.
diff --git a/numpy/core/function_base.py b/numpy/core/function_base.py
@@ -25,7 +25,7 @@ def linspace(start, stop, num=50, endpoint=True, retstep=False, dtype=None):
         evenly spaced samples, so that `stop` is excluded.  Note that the step
         size changes when `endpoint` is False.
     num : int, optional
-        Number of samples to generate. Default is 50.
+        Number of samples to generate. Default is 50. Must be non-negative.
     endpoint : bool, optional
         If True, `stop` is the last sample. Otherwise, it is not included.
         Default is True.
@@ -82,6 +82,8 @@ def linspace(start, stop, num=50, endpoint=True, retstep=False, dtype=None):
 
     """
     num = int(num)
+    if num < 0:
+        raise ValueError("Number of samples, %s, must be non-negative." % num)
     div = (num - 1) if endpoint else num
 
     # Convert float/complex array scalars to float, gh-3504
diff --git a/numpy/core/tests/test_function_base.py b/numpy/core/tests/test_function_base.py
@@ -34,6 +34,7 @@ def test_basic(self):
         assert_(y[-1] == 10)
         y = linspace(2, 10, endpoint=0)
         assert_(y[-1] < 10)
+        assert_raises(ValueError, linspace, 0, 10, num=-1)
 
     def test_corner(self):
         y = list(linspace(0, 1, 1))
