Catch and log exceptions from user callbacks in AsyncHTTPClient.

Ben Darnell · Ben Darnell · commit 27171cde8440 · 2010-06-08T11:48:43.000-07:00
diff --git a/tornado/httpclient.py b/tornado/httpclient.py
@@ -287,10 +287,16 @@ def _finish(self, curl, curl_error=None, curl_message=None):
             code = curl.getinfo(pycurl.HTTP_CODE)
             effective_url = curl.getinfo(pycurl.EFFECTIVE_URL)
             buffer.seek(0)
-        info["callback"](HTTPResponse(
-            request=info["request"], code=code, headers=info["headers"],
-            buffer=buffer, effective_url=effective_url, error=error,
-            request_time=time.time() - info["start_time"]))
+        try:
+            info["callback"](HTTPResponse(
+                request=info["request"], code=code, headers=info["headers"],
+                buffer=buffer, effective_url=effective_url, error=error,
+                request_time=time.time() - info["start_time"]))
+        except (KeyboardInterrupt, SystemExit):
+            raise
+        except:
+            logging.error("Exception in callback %r", info["callback"],
+                          exc_info=True)
 
 
 class HTTPRequest(object):
