Merge pull request kelektiv#154 from nel215/feature/throw_error_instance_in_set_time

ncb000gt · ncb000gt · commit 394c3673ac25 · 2015-03-26T08:03:42.000-04:00
Modified CronJob.prototype.setTime to throw error instance
diff --git a/lib/cron.js b/lib/cron.js
@@ -375,7 +375,7 @@ var addCallback = function(callback) {
 CronJob.prototype.addCallback = addCallback;
 
 CronJob.prototype.setTime = function(time) {
-	if (!(time instanceof CronTime)) throw '\'time\' must be an instance of CronTime.';
+	if (!(time instanceof CronTime)) throw new Error('\'time\' must be an instance of CronTime.');
 	this.stop();
 	this.cronTime = time;
 }
diff --git a/tests/test-cron.js b/tests/test-cron.js
@@ -365,7 +365,7 @@ module.exports = testCase({
 		job.stop();
 		assert.throws(function() {
 			job.setTime(time);
-		});
+		}, Error, '\'time\' must be an instance of CronTime.');
 
 		clock.restore();
 		job.stop();

Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@ var addCallback = function(callback) {`
`375`	`375`	`CronJob.prototype.addCallback = addCallback;`
`376`	`376`
`377`	`377`	`CronJob.prototype.setTime = function(time) {`
`378`		`- if (!(time instanceof CronTime)) throw '\'time\' must be an instance of CronTime.';`
	`378`	`+ if (!(time instanceof CronTime)) throw new Error('\'time\' must be an instance of CronTime.');`
`379`	`379`	`this.stop();`
`380`	`380`	`this.cronTime = time;`
`381`	`381`	`}`