Add support for buffering kwarg in urllib3.

Philip K. Warren · Philip K. Warren · commit d9c971470a19 · 2012-04-02T11:02:45.000-05:00
diff --git a/urllib3/connectionpool.py b/urllib3/connectionpool.py
@@ -172,6 +172,7 @@ def __init__(self, host, port=None, strict=False, timeout=None, maxsize=1,
         self.pool = self.QueueCls(maxsize)
         self.block = block
         self.headers = headers or {}
+        self._buffering = True
 
         # Fill the queue up so that doing get() on it will block properly
         for _ in xrange(maxsize):
@@ -258,7 +259,15 @@ def _make_request(self, conn, method, url, timeout=_Default,
         if sock:
             sock.settimeout(timeout)
 
-        httplib_response = conn.getresponse()
+        if self._buffering:
+            try:
+                httplib_response = conn.getresponse(buffering=True)
+            except TypeError:
+                # Don't try buffering again - kwarg not supported
+                self._buffering = False
+                httplib_response = conn.getresponse()
+        else:
+            httplib_response = conn.getresponse()
 
         # AppEngine doesn't have a version attr.
         http_version = getattr(conn, '_http_vsn_str', 'HTTP/?'),
