Trying to make the reviewer happy

kohsuke · kohsuke · commit 633ce4e97986 · 2016-03-08T14:35:08.000-08:00
diff --git a/src/main/resources/org/jenkinsci/plugins/github/config/GitHubPluginConfig/config.groovy b/src/main/resources/org/jenkinsci/plugins/github/config/GitHubPluginConfig/config.groovy
@@ -10,7 +10,8 @@ f.section(title: descriptor.displayName) {
         
         f.repeatableHeteroProperty(
                 field: "configs",
-                hasHeader: "true")
+                hasHeader: "true",
+                addCaption: _("Add GitHub Server"))
     }
 
     f.advanced() {
diff --git a/src/test/java/org/jenkinsci/plugins/github/internal/GitHubClientCacheCleanupTest.java b/src/test/java/org/jenkinsci/plugins/github/internal/GitHubClientCacheCleanupTest.java
@@ -105,7 +105,7 @@ private void makeCachedRequestWithCredsId(String credsId) throws IOException {
         GitHubServerConfig config = new GitHubServerConfig(credsId);
         config.setApiUrl(github.serverConfig().getApiUrl());
         config.setClientCacheSize(1);
-        GitHub gitHub = new GitHubLoginFunction().apply(config);
+        GitHub gitHub = GitHubServerConfig.loginToGithub().apply(config);
         gitHub.getMyself();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,8 @@ f.section(title: descriptor.displayName) {`
`10`	`10`
`11`	`11`	`f.repeatableHeteroProperty(`
`12`	`12`	`field: "configs",`
`13`		`- hasHeader: "true")`
	`13`	`+ hasHeader: "true",`
	`14`	`+ addCaption: _("Add GitHub Server"))`
`14`	`15`	`}`
`15`	`16`
`16`	`17`	`f.advanced() {`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ private void makeCachedRequestWithCredsId(String credsId) throws IOException {`
`105`	`105`	`GitHubServerConfig config = new GitHubServerConfig(credsId);`
`106`	`106`	`config.setApiUrl(github.serverConfig().getApiUrl());`
`107`	`107`	`config.setClientCacheSize(1);`
`108`		`- GitHub gitHub = new GitHubLoginFunction().apply(config);`
	`108`	`+ GitHub gitHub = GitHubServerConfig.loginToGithub().apply(config);`
`109`	`109`	`gitHub.getMyself();`
`110`	`110`	`}`
`111`	`111`	`}`