[JENKINS-36144] After careful analysis of some of the code paths, safer not to borrow

stephenc · stephenc · commit 05b895f64d31 · 2016-06-22T12:31:57.000+01:00
- we will mirror the count though
diff --git a/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java b/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
@@ -18,8 +18,6 @@
 import hudson.util.NamingThreadFactory;
 import hudson.util.SequentialExecutionQueue;
 import hudson.util.StreamTaskListener;
-import java.lang.reflect.Field;
-import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ThreadFactory;
 import jenkins.model.Jenkins;
@@ -262,22 +260,10 @@ synchronized void checkThreadPoolSize() {
             if (scmTrigger != null) {
                 int count = scmTrigger.getPollingThreadCount();
                 if (maximumThreads != count) {
-                    maximumThreads = count;
-                    try {
-                        Field getQueue = SCMTrigger.DescriptorImpl.class.getDeclaredField("queue");
-                        getQueue.setAccessible(true);
-                        SequentialExecutionQueue q = (SequentialExecutionQueue) getQueue.get(scmTrigger);
-                        ExecutorService executors = q.getExecutors();
-                        if (this.queue.getExecutors() != executors) {
-                            // guard or otherwise we will shut it down :-(
-                            this.queue.setExecutors(executors);
-                        }
-                    } catch (NoSuchFieldException | IllegalAccessException | ClassCastException e) {
-                        queue.setExecutors(
-                                (count == 0
-                                        ? Executors.newCachedThreadPool(threadFactory())
-                                        : Executors.newFixedThreadPool(maximumThreads, threadFactory())));
-                    }
+                    queue.setExecutors(
+                            (count == 0
+                                    ? Executors.newCachedThreadPool(threadFactory())
+                                    : Executors.newFixedThreadPool(maximumThreads, threadFactory())));
                 }
             }
         }
