8000 Fix for older set versions · github/ruby@fd3dede · GitHub
[go: up one dir, main page]

Skip to content

Commit fd3dede

Browse files
committed
Fix for older set versions
`Set::VERSION` was not defined in old set.rb bundled with ruby 3.2 or earlier. Also add comment for spec/mspec/tool/remove_old_guards.rb.
1 parent dc7785e commit fd3dede

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

spec/ruby/library/set/flatten_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
require_relative '../../spec_helper'
22
require_relative 'fixtures/set_like'
33
require 'set'
4+
set_version = defined?(Set::VERSION) ? Set::VERSION : '1.0.0'
45

56
describe "Set#flatten" do
67
it "returns a copy of self with each included Set flattened" do
@@ -45,7 +46,7 @@
4546
-> { set.flatten! }.should raise_error(ArgumentError)
4647
end
47 8000 48

48-
version_is(Set::VERSION, ""..."1.1.0") do
49+
version_is(set_version, ""..."1.1.0") do #ruby_version_is ""..."3.3" do
4950
context "when Set contains a Set-like object" do
5051
it "flattens self, including Set-like objects" do
5152
Set[SetSpecs::SetLike.new([1])].flatten!.should == Set[1]

spec/ruby/library/set/proper_subset_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
require_relative '../../spec_helper'
22
require_relative 'fixtures/set_like'
33
require 'set'
4+
set_version = defined?(Set::VERSION) ? Set::VERSION : '1.0.0'
45

56
describe "Set#proper_subset?" do
67
before :each do
@@ -33,7 +34,7 @@
3334
-> { Set[].proper_subset?(Object.new) }.should raise_error(ArgumentError)
3435
end
3536

36-
version_is(Set::VERSION, ""..."1.1.0") do
37+
version_is(set_version, ""..."1.1.0") do #ruby_version_is ""..."3.3" do
3738
context "when comparing to a Set-like object" do
3839
it "returns true if passed a Set-like object that self is a proper subset of" do
3940
Set[1, 2, 3].proper_subset?(SetSpecs::SetLike.new([1, 2, 3, 4])).should be_true

spec/ruby/library/set/subset_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
require_relative '../../spec_helper'
22
require_relative 'fixtures/set_like'
33
require 'set'
4+
set_version = defined?(Set::VERSION) ? Set::VERSION : '1.0.0'
45

56
describe "Set#subset?" do
67
before :each do
@@ -33,7 +34,7 @@
3334
-> { Set[].subset?(Object.new) }.should raise_error(ArgumentError)
3435
end
3536

36-
version_is(Set::VERSION, ""..."1.1.0") do
37+
version_is(set_version, ""..."1.1.0") do #ruby_version_is ""..."3.3" do
3738
context "when comparing to a Set-like object" do
3839
it "returns true if passed a Set-like object that self is a subset of" do
3940
Set[1, 2, 3].subset?(SetSpecs::SetLike.new([1, 2, 3, 4])).should be_true

0 commit comments

Comments
 (0)
0