merge revision(s) r47696,r47697: [Backport ruby#10279]

nagachika · dbussink · commit da7ec4069800 · 2014-09-29T09:59:03.000+02:00
* parse.y (parse_ident): just after a label, new expression should start, cannot be a modifier. [ruby-core:65211] [Bug ruby#10279] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Conflicts: ChangeLog version.h
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,8 @@
+Wed Sep 24 02:30:55 2014  Nobuyoshi Nakada  <nobu@ruby-lang.org>
+
+	* parse.y (parse_ident): just after a label, new expression should
+	  start, cannot be a modifier.  [ruby-core:65211] [Bug #10279]
+
 Fri Mar  7 12:06:19 2014  Martin Bosslet  <Martin.Bosslet@gmail.com>
 
 	* test/openssl/test_ssl.rb: Reuse TLS default options from
diff --git a/parse.y b/parse.y
@@ -8195,7 +8195,7 @@ parser_yylex(struct parser_params *parser)
 			    return keyword_do_block;
 			return keyword_do;
 		    }
-		    if (IS_lex_state_for(state, (EXPR_BEG | EXPR_VALUE)))
+		    if (IS_lex_state_for(state, (EXPR_BEG | EXPR_VALUE | EXPR_LABELARG)))
 			return kw->id[0];
 		    else {
 			if (kw->id[0] != kw->id[1])
diff --git a/test/ruby/test_keyword.rb b/test/ruby/test_keyword.rb
@@ -325,7 +325,9 @@ def test_required_keyword
     assert_equal([[:keyreq, :a], [:keyrest, :b]], o.method(:bar).parameters, feature7701)
     assert_raise_with_message(ArgumentError, /missing keyword/, bug8139) {o.bar(c: bug8139)}
     assert_raise_with_message(ArgumentError, /missing keyword/, bug8139) {o.bar}
+  end
 
+  def test_required_keyword_with_newline
     bug9669 = '[ruby-core:61658] [Bug #9669]'
     assert_nothing_raised(SyntaxError, bug9669) do
       eval(<<-'end;', nil, __FILE__, __LINE__)
@@ -335,6 +337,7 @@ def bug9669.foo a:
       end;
     end
     assert_equal(42, bug9669.foo(a: 42))
+    o = nil
     assert_nothing_raised(SyntaxError, bug9669) do
       eval(<<-'end;', nil, __FILE__, __LINE__)
         o = {
@@ -346,6 +349,17 @@ def bug9669.foo a:
     assert_equal({a: 1}, o, bug9669)
   end
 
+  def test_required_keyword_with_reserved
+    bug10279 = '[ruby-core:65211] [Bug #10279]'
+    h = nil
+    assert_nothing_raised(SyntaxError, bug10279) do
+      break eval(<<-'end;', nil, __FILE__, __LINE__)
+        h = {a: if true then 42 end}
+      end;
+    end
+    assert_equal({a: 42}, h, bug10279)
+  end
+
   def test_block_required_keyword
     feature7701 = '[ruby-core:51454] [Feature #7701] required keyword argument'
     b = assert_nothing_raised(SyntaxError, feature7701) do

Original file line number	Diff line number	Diff line change
`@@ -8195,7 +8195,7 @@ parser_yylex(struct parser_params *parser)`
`8195`	`8195`	`return keyword_do_block;`
`8196`	`8196`	`return keyword_do;`
`8197`	`8197`	`}`
`8198`		`- if (IS_lex_state_for(state, (EXPR_BEG \| EXPR_VALUE)))`
	`8198`	`+ if (IS_lex_state_for(state, (EXPR_BEG \| EXPR_VALUE \| EXPR_LABELARG)))`
`8199`	`8199`	`return kw->id[0];`
`8200`	`8200`	`else {`
`8201`	`8201`	`if (kw->id[0] != kw->id[1])`