merge revision(s) r45468: [Backport ruby#9687]

nagachika · nagachika · commit d8eba4057a63 · 2014-05-04T16:17:08.000Z
* gc.c (gc_before_sweep): cap `malloc_limit' to gc_params.malloc_limit_max. It can grow and grow with such case: `loop{"a" * (1024 ** 2)}' [Bug ruby#9687] This issue is pointed by Tim Robertson. http://www.omniref.com/blog/blog/2014/03/27/ruby-garbage-collection-still-not-ready-for-production/ git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@45817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,13 @@
+Mon May  5 01:13:00 2014  Koichi Sasada  <ko1@atdot.net>
+
+	* gc.c (gc_before_sweep): cap `malloc_limit' to
+	  gc_params.malloc_limit_max.  It can grow and grow with such case:
+	    `loop{"a" * (1024 ** 2)}'
+	  [Bug #9687]
+
+	  This issue is pointed by Tim Robertson.
+	  http://www.omniref.com/blog/blog/2014/03/27/ruby-garbage-collection-still-not-ready-for-production/
+
 Mon May  5 00:52:18 2014  Kenta Murata  <mrkn@mrkn.jp>
 
 	* ext/bigdecimal/bigdecimal.c (BigDecimal_initialize): Insert GC guard.
diff --git a/gc.c b/gc.c
@@ -2886,7 +2886,7 @@ gc_before_sweep(rb_objspace_t *objspace)
 	    malloc_limit = (size_t)(inc * gc_params.malloc_limit_growth_factor);
 	    if (gc_params.malloc_limit_max > 0 && /* ignore max-check if 0 */
 		malloc_limit > gc_params.malloc_limit_max) {
-		malloc_limit = inc;
+		malloc_limit = gc_params.malloc_limit_max;
 	    }
 	}
 	else {
diff --git a/version.h b/version.h
@@ -1,6 +1,6 @@
 #define RUBY_VERSION "2.1.2"
 #define RUBY_RELEASE_DATE "2014-05-05"
-#define RUBY_PATCHLEVEL 87
+#define RUBY_PATCHLEVEL 88
 
 #define RUBY_RELEASE_YEAR 2014
 #define RUBY_RELEASE_MONTH 5

Original file line number	Diff line number	Diff line change
`@@ -2886,7 +2886,7 @@ gc_before_sweep(rb_objspace_t *objspace)`
`2886`	`2886`	`malloc_limit = (size_t)(inc * gc_params.malloc_limit_growth_factor);`
`2887`	`2887`	`if (gc_params.malloc_limit_max > 0 && /* ignore max-check if 0 */`
`2888`	`2888`	`malloc_limit > gc_params.malloc_limit_max) {`
`2889`		`- malloc_limit = inc;`
	`2889`	`+ malloc_limit = gc_params.malloc_limit_max;`
`2890`	`2890`	`}`
`2891`	`2891`	`}`
`2892`	`2892`	`else {`